From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCHES] Add vsearch.
Date: Thu, 01 Oct 2015 10:55:40 +0200
Message-ID: <87eghfq86r.fsf@gnu.org>
References: <560A82F5.4090200@uq.edu.au> <560B9F35.7090405@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZhZeX-0001A7-9u
	for guix-devel@gnu.org; Thu, 01 Oct 2015 04:55:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZhZeT-0000rE-98
	for guix-devel@gnu.org; Thu, 01 Oct 2015 04:55:49 -0400
In-Reply-To: <560B9F35.7090405@uq.edu.au> (Ben Woodcroft's message of "Wed, 30
	Sep 2015 18:37:09 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> From e1789cbcfcf7dc6f1657f53bad04fca7180400cc Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Tue, 29 Sep 2015 22:10:33 +1000
> Subject: [PATCH 1/2] gnu: Add cityhash.
>
> * gnu/packages/textutils.scm (cityhash): New variable.

Applied.  I removed =E2=80=9CA=E2=80=9D from the synopsis as suggested by =
=E2=80=98guix lint=E2=80=99.

> From 5a403f43bafe129d8a22b1d0ea169c2e97d2fb5b Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Wed, 30 Sep 2015 18:35:32 +1000
> Subject: [PATCH 2/2] gnu: Add vsearch.
>
> * gnu/packages/bioinformatics.scm (vsearch): New variable.

[...]

> +           ;; Remove bundled cityhash
> +           (substitute* "src/Makefile.am"
> +             (((string-append "^AM_CXXFLAGS=3D-I\\$\\{srcdir\\}/cityhash"
> +                              " -O3 -mtune=3Dnative -Wall -Wsign-compare=
"))
> +              (string-append "AM_CXXFLAGS=3D-lcityhash"
> +                             " -O3 -mtune=3Dnative -Wall -Wsign-compare"=
))

I changed that to remove -mtune=3Dnative, which would produce binaries
that can only work on the build machine, and to use a string literal for
the pattern.

Thanks!

Ludo=E2=80=99.