Re: [PATCHES] Add vsearch.

[ludo@gnu.org (Ludovic Courtès)]

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> From e1789cbcfcf7dc6f1657f53bad04fca7180400cc Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Tue, 29 Sep 2015 22:10:33 +1000
> Subject: [PATCH 1/2] gnu: Add cityhash.
>
> * gnu/packages/textutils.scm (cityhash): New variable.

Applied.  I removed “A” from the synopsis as suggested by ‘guix lint’.

> From 5a403f43bafe129d8a22b1d0ea169c2e97d2fb5b Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Wed, 30 Sep 2015 18:35:32 +1000
> Subject: [PATCH 2/2] gnu: Add vsearch.
>
> * gnu/packages/bioinformatics.scm (vsearch): New variable.

[...]

> +           ;; Remove bundled cityhash
> +           (substitute* "src/Makefile.am"
> +             (((string-append "^AM_CXXFLAGS=-I\\$\\{srcdir\\}/cityhash"
> +                              " -O3 -mtune=native -Wall -Wsign-compare"))
> +              (string-append "AM_CXXFLAGS=-lcityhash"
> +                             " -O3 -mtune=native -Wall -Wsign-compare"))

I changed that to remove -mtune=native, which would produce binaries
that can only work on the build machine, and to use a string literal for
the pattern.

Thanks!

Ludo’.