From: ludo@gnu.org (Ludovic Courtès)
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCHES] Add vsearch.
Date: Thu, 01 Oct 2015 10:55:40 +0200 [thread overview]
Message-ID: <87eghfq86r.fsf@gnu.org> (raw)
In-Reply-To: <560B9F35.7090405@uq.edu.au> (Ben Woodcroft's message of "Wed, 30 Sep 2015 18:37:09 +1000")
Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
> From e1789cbcfcf7dc6f1657f53bad04fca7180400cc Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Tue, 29 Sep 2015 22:10:33 +1000
> Subject: [PATCH 1/2] gnu: Add cityhash.
>
> * gnu/packages/textutils.scm (cityhash): New variable.
Applied. I removed “A” from the synopsis as suggested by ‘guix lint’.
> From 5a403f43bafe129d8a22b1d0ea169c2e97d2fb5b Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Wed, 30 Sep 2015 18:35:32 +1000
> Subject: [PATCH 2/2] gnu: Add vsearch.
>
> * gnu/packages/bioinformatics.scm (vsearch): New variable.
[...]
> + ;; Remove bundled cityhash
> + (substitute* "src/Makefile.am"
> + (((string-append "^AM_CXXFLAGS=-I\\$\\{srcdir\\}/cityhash"
> + " -O3 -mtune=native -Wall -Wsign-compare"))
> + (string-append "AM_CXXFLAGS=-lcityhash"
> + " -O3 -mtune=native -Wall -Wsign-compare"))
I changed that to remove -mtune=native, which would produce binaries
that can only work on the build machine, and to use a string literal for
the pattern.
Thanks!
Ludo’.
next prev parent reply other threads:[~2015-10-01 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 12:24 [PATCHES] Add vsearch Ben Woodcroft
2015-09-30 2:44 ` Ben Woodcroft
2015-09-30 8:37 ` Ben Woodcroft
2015-10-01 8:55 ` Ludovic Courtès [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-29 22:47 Ben Woodcroft
2015-10-01 14:05 ` Ludovic Courtès
2015-10-01 19:41 ` Andreas Enge
2015-10-02 11:40 ` Ricardo Wurmus
2015-10-02 18:05 ` Andreas Enge
2015-10-03 1:59 ` Ben Woodcroft
2015-10-03 12:00 ` Andreas Enge
2015-10-03 20:50 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eghfq86r.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.