all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add python-statsmodels.
Date: Mon, 19 Oct 2015 17:47:16 +0200	[thread overview]
Message-ID: <87eggqyi63.fsf@gnu.org> (raw)
In-Reply-To: <idj8u72zzyq.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 16 Oct 2015 15:48:29 +0200")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> the attached patch adds python{,2}-statsmodels to statistics.scm.  Note
> that this depends on my previous patch adding patsy to the same module.

Hmm I lost track of patsy in my inbox.  I’ll check afterwards.

> From 33ddc045065722a0bac9b28ad909e838b169d7cb Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 13 Oct 2015 13:28:58 +0200
> Subject: [PATCH 1/2] gnu: Add python-statsmodels.
>
> * gnu/packages/statistics.scm (python-statsmodels, python2-statsmodels):
>   New variables.

LGTM.

> +         (add-after 'unpack 'set-matplotlib-backend-to-agg
> +          (lambda _
> +            ;; Set the matplotlib backend to Agg to avoid problems using the
> +            ;; GTK backend without a display.
> +            (substitute* (find-files "statsmodels/graphics/tests" "\\.py")
> +              (("import matplotlib\\.pyplot as plt" line)
> +               (string-append "import matplotlib;matplotlib.use('Agg');"
> +                              line)))

This looks good.  Should we eventually change Matplotlib itself to use
this back-end by default?  What’s at stake exactly?

Thanks!

Ludo’.

  reply	other threads:[~2015-10-19 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 13:48 [PATCH] Add python-statsmodels Ricardo Wurmus
2015-10-19 15:47 ` Ludovic Courtès [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-10-19 16:15 Federico Beffa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eggqyi63.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.