Re: [PATCH 6/6] gnu: Add emacs-slime.

[ludo@gnu.org (Ludovic Courtès)]

Federico Beffa <beffa@ieee.org> skribis:

> From e3dd3f2235b9aed36d213f68ea767225ec8ebd61 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Wed, 30 Dec 2015 00:47:29 +0100
> Subject: [PATCH 6/6] gnu: Add emacs-slime.
>
> * gnu/packages/emacs.scm (emacs-slime): New variable.

[...]

> +    (inputs
> +     `(("texlive" ,texlive)
> +       ("texinfo" ,texinfo)))

Should be ‘native-inputs’.

> +         (add-before 'install 'install-doc
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (info-dir (string-append out "/share/info"))
> +                    (doc-dir (string-append out "/share/doc/"
> +                                            ,name "-" ,version))
> +                    (doc-files '("doc/slime.pdf" "doc/slime-refcard.pdf"
> +                                 "README.md" "NEWS" "PROBLEMS"
> +                                 "CONTRIBUTING.md")))
> +               (with-directory-excursion "doc"
> +                 (substitute* "Makefile"
> +                   (("infodir=/usr/local/info")
> +                    (string-append "infodir=" info-dir)))
> +                 (system* "make" "all")
> +                 (install-file "slime.info" info-dir)
> +                 (copy-recursively "html" (string-append doc-dir "/html")))
> +               (for-each (lambda (f)
> +                           (install-file f doc-dir)
> +                           (delete-file f))
> +                         doc-files)
> +               (delete-file-recursively "doc")

Can we build and install only Info files?  This is what we usually do
for packages that have Texinfo manuals.  Incidentally, it allows us to
get rid of the TeX Live dependency.

> +    (synopsis
> +     "Superior Lisp Interaction Mode for Emacs")

Move to previous line.

> +    (description
> +     "SLIME extends Emacs with support for interactive programming in
> +Common Lisp.  The features are centered around slime-mode, an Emacs

@code{slime-mode}

> +minor-mode that complements the standard lisp-mode.  While lisp-mode

s/minor-mode/minor mode/
@code{lisp-mode}

> +supports editing Lisp source files, slime-mode adds support for

@code{slime-mode}

> +interacting with a running Common Lisp process for compilation,
> +debugging, documentation lookup, and so on.")

Could you send an updated patch?

Thanks,
Ludo’.