From: Christopher Allan Webber <cwebber@dustycloud.org>
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add and use sqlite-legacy-for-python
Date: Fri, 12 Feb 2016 17:09:58 -0800 [thread overview]
Message-ID: <87egch8lg9.fsf@dustycloud.org> (raw)
In-Reply-To: <CAJ=RwfZkasyp6t3emfizRd5oP2-bZ1dHQJRZvMT4mvrBu-=Sig@mail.gmail.com>
Thompson, David writes:
> On Fri, Feb 12, 2016 at 7:13 PM, Christopher Allan Webber
> <cwebber@dustycloud.org> wrote:
>> Ludovic Courtès writes:
>>
>>> Pjotr Prins <pjotr.public12@thebird.nl> skribis:
>>>
>>>> Patch b24765139c8940541b23f84592d3580d53f71d71
>>>>
>>>> (define-public sqlite
>>>> (package
>>>> (name "sqlite")
>>>> - (version "3.8.11.1")
>>>> + (version "3.10.0")
>>>> (source (origin
>>>>
>>>> is the cause of python(2|3)-sqlalchemy breaking. I confirmed that by
>>>> regressing to the original sqlite package. Since the python binding is
>>>> part of the interpreter, I suspect there may be more python modules
>>>> vulnerable. I updated python-sqlalchemy to latest and that makes no
>>>> difference. Its tests fail on sqlite 3.10.0 and pass on 3.8.11.1.
>>>>
>>>> What do we do? Revert on this sqlite patch for the new guix release?
>>>> Or add a second sqlite package and have that as a python dependency?
>>>
>>> I would do the latter, assuming that soon a new python-sqlalchemy
>>> release would solve the problem. WDYT?
>>>
>>> This is probably OK since python-sqlalchemy is a leaf, and so we’re
>>> unlikely to end up mixing two different SQLite versions.
>>>
>>> Ludo’.
>>
>> Will sqlalchemy really remain a leaf node? I hope not, since I'm
>> working on packaging MediaGoblin now :)
>
> Yeah, sqlalchemy being a leaf node is accidental. It's a library that
> will be depended on by MediaGoblin and maybe other software.
>
>> Regardless, I agree that the second approach seems to be the right one.
>> I've built a modified package, sqlite-legacy-for-python, and put it to
>> use. I built it and confirmed it builds fine and that the tests pass,
>> and with it, the tests pass in python-sqlalchemy too.
>
> I'm concerned about this. What exactly is being used here, a client
> library? If so, it means that we may have an issue when a python
> application uses a library that wants to dynamically link against both
> the normal sqlite library and this older version. Maybe this is still
> fine, but proceed with caution.
>
> - Dave
I share your concern, and admittedly don't understand myself what the
implications are here (despite producing a patch, egads!). It's part of
the standard library though. I would *think* that it would stay
pointing at the very specific version of sqlite. Nonetheless, it does
seem unsettling, and unclear to me personally if something unexpected
could happen.
Maybe some "expert" could weigh in... :)
next prev parent reply other threads:[~2016-02-13 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 16:46 sqlite update causes failure of python-sqlalchemy Pjotr Prins
2016-02-09 21:15 ` Ludovic Courtès
2016-02-13 0:13 ` [PATCH] Add and use sqlite-legacy-for-python Christopher Allan Webber
2016-02-13 0:23 ` Thompson, David
2016-02-13 1:09 ` Christopher Allan Webber [this message]
2016-02-15 2:40 ` Christopher Allan Webber
2016-02-15 19:38 ` Christopher Allan Webber
2016-02-15 20:13 ` Christopher Allan Webber
2016-02-15 21:03 ` Pjotr Prins
2016-02-21 21:11 ` Ludovic Courtès
2016-02-13 7:59 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egch8lg9.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.