From: Christopher Allan Webber <cwebber@dustycloud.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add python-psycopg2, python2-psycopg2
Date: Sun, 21 Feb 2016 18:38:51 -0800 [thread overview]
Message-ID: <87egc54gg4.fsf@dustycloud.org> (raw)
In-Reply-To: <20160222013949.186f25bc@scratchpost.org>
Danny Milosavljevic writes:
> Hi,
>
> On Fri, 19 Feb 2016 16:22:58 -0500
> Leo Famulari <leo@famulari.name> wrote:
>
>> > + `(#:tests? #f)) ; TODO re-enable
>>
>> Why are the tests disabled?
>
> Because it would require a postgresql database "psycopg2_test" and a
> running postgresql database management service.
>
> Not sure what the usual way to do that is. Should it create the db on
> a temporary dbms service on-the-fly and drop it later?
>
> Or we could mock out the server and just have it return constant stuff
> as if it was postgresql. Is that already available somewhere?
My personal suggestion would be to push to master without the tests for
now, and add a comment explaining why this is hard. I think someone
needs to figure out a nice way to spin up a mini-service for running
postgres during tests; some of my stuff could use that too. But we
should merge and push this with an additional comment.
next prev parent reply other threads:[~2016-02-22 2:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 11:01 [PATCH] gnu: Add python-psycopg2, python2-psycopg2 Danny Milosavljevic
2016-02-19 21:22 ` Leo Famulari
2016-02-22 0:39 ` Danny Milosavljevic
2016-02-22 2:38 ` Christopher Allan Webber [this message]
2016-02-24 22:39 ` [PATCH v2] " Danny Milosavljevic
2016-02-25 0:05 ` Christopher Allan Webber
2016-02-25 0:52 ` [PATCH v3] " Danny Milosavljevic
2016-02-25 17:53 ` Christopher Allan Webber
2016-02-25 19:30 ` Leo Famulari
2016-02-25 21:28 ` Christopher Allan Webber
2016-02-25 21:35 ` Leo Famulari
2016-02-25 22:22 ` Danny Milosavljevic
2016-02-25 22:45 ` Christopher Allan Webber
2016-02-25 23:13 ` Leo Famulari
2016-02-25 23:52 ` Christopher Allan Webber
2016-02-22 2:39 ` [PATCH] " Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egc54gg4.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.