From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 1/2] gnu: Add freealut. Date: Mon, 21 Mar 2016 22:24:26 +0100 Message-ID: <87egb334ol.fsf@mdc-berlin.de> References: <1458370575-388-1-git-send-email-david.hashe@dhashe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai7JY-0006mk-F1 for guix-devel@gnu.org; Mon, 21 Mar 2016 17:24:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai7JV-0004P9-0X for guix-devel@gnu.org; Mon, 21 Mar 2016 17:24:40 -0400 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:41230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai7JU-0004Or-Jh for guix-devel@gnu.org; Mon, 21 Mar 2016 17:24:36 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Hashe Cc: guix-devel@gnu.org David Hashe writes: >> I see that Arch and Fedora both use the tarball from here: >> >> >> http://pkgs.fedoraproject.org/repo/pkgs/freealut/freealut-1.1.0.tar.gz= /e089b28a0267faabdb6c079ee173664a/freealut-1.1.0.tar.gz >> >> The advantage of that tarball is that it doesn=E2=80=99t require boots= trapping, >> so you can do without the additional =E2=80=9Cautogen=E2=80=9D phase a= nd without the >> three native inputs. >> > > Done. By the way, where exactly do you find what tarball Arch and Fedor= a > use for a given package? I couldn't seem to find that information on a > cursory glance. I looked at the PKGBUILD of the Arch package. >> Does Freealut itself have a home page? It doesn=E2=80=99t seem right = to me to >> declare the website of OpenAL as the home page, when the package is >> really just one implemenatation of the standard published on the OpenA= L >> website. >> >> > I agree, but it doesn't seem to have a separate home page. Debian simpl= y > lists the home page as "http://www.openal.org/", for instance. I could = set > the field to #f, but guix lint complains about that and it looks like o= nly > the bootstrap-binaries actually do that. For now, I've added a comment > clarifying the situation. That=E2=80=99s good, thanks. The patch looks pretty good to me now, except maybe for this + (uri + (let ((name-version-tar + (string-append name "-" version ".tar.gz"))) + (string-append + "http://pkgs.fedoraproject.org/repo/pkgs/" name "/" + name-version-tar "/" + "e089b28a0267faabdb6c079ee173664a/" + name-version-tar))) I find the let binding a bit too ... much :) But if nobody else has a problem with this, I wouldn=E2=80=99t complain. Thanks! ~~ Ricardo