Re: [PATCH 2/6] gnu: gnome-documents

[ludo@gnu.org (Ludovic Courtès)]

rennes@openmailbox.org skribis:

> From a9fa68e37bd262a9f0b7ba999c163964beba4995 Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <rennes@openmailbox.org>
> Date: Wed, 13 Apr 2016 23:45:12 -0500
> Subject: [PATCH] gnu: Add tracker.
>
> * gnu/packages/gnome.scm (tracker): New variable.
> * gnu/packages/patches/tracker-db-journal.patch: New file.
> * gnu/packages/patches/tracker-dbus-test.patch: New file.
> * gnu/packages/patches/tracker-gb-737023.patch: New file.
> * gnu/packages/patches/tracker-ontology.patch: New file.
> * gnu/packages/patches/tracker-steroids-test.patch: New file.
> * gnu/packages/patches/tracker-test.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
>
> Co-authored-by: Ludovic Court\xc3\xa8s <ludo@gnu.org>

[...]

> +++ b/gnu/packages/patches/tracker-db-journal.patch
> @@ -0,0 +1,18 @@
> +Skip the 'tracker-db-journal'. 

Missing word: “test”.

Could you add a few words as to why we must skip this test?  It’s
important to keep track of why we skip tests when we do, so we can be
confident about the choices we make and maintain them in the future.

> +++ b/gnu/packages/patches/tracker-ontology.patch
> @@ -0,0 +1,17 @@
> +Skip the 'tracker-ontology-test'.

Likewise.

> +++ b/gnu/packages/patches/tracker-steroids-test.patch
> @@ -0,0 +1,15 @@
> +Skip the 'tracker.test', connection is attempted.

Connection to what?  Could you clarify this?

Otherwise LGTM, we’re almost there!

Could you send an updated patch?

Thank you!

Ludo’.