From: ludo@gnu.org (Ludovic Courtès)
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>,
David Thompson <davet@gnu.org>
Subject: Re: [PATCH 01/10] gnu: Add emacs-smex.
Date: Fri, 03 Jun 2016 10:14:23 +0200 [thread overview]
Message-ID: <87eg8e4rkw.fsf@gnu.org> (raw)
In-Reply-To: <CAJ=Rwfb1cJN2KKUO4y1QhrJ561zaStdk5DMLpV7TUKUHJw+3eQ@mail.gmail.com> (David Thompson's message of "Thu, 2 Jun 2016 09:33:35 -0400")
"Thompson, David" <dthompson2@worcester.edu> skribis:
> On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost <alezost@gmail.com> wrote:
>> David Thompson (2016-06-01 17:05 +0300) wrote:
>>
>>> From: David Thompson <davet@gnu.org>
>>>
>>> * gnu/packages/emacs.scm (emacs-smex): New variable.
>>> ---
>>> gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>>> 1 file changed, 22 insertions(+)
>>>
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index b7c0a1f..71f2f8b 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -10,6 +10,7 @@
>>> ;;; Copyright © 2015, 2016 Christopher Allan Webber <cwebber@dustycloud.org>
>>> ;;; Copyright © 2016 humanitiesNerd <catonano@gmail.com>
>>> ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
>>> +;;; Copyright © 2016 David Thompson <davet@gnu.org>
>>> ;;;
>>> ;;; This file is part of GNU Guix.
>>> ;;;
>>> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
>>> Emacs default configuration in uncontroversial ways that nearly everyone can
>>> agree upon.")
>>> (license license:gpl3+)))
>>> +
>>> +(define-public emacs-smex
>>> + (package
>>> + (name "emacs-smex")
>>> + (version "3.0")
>>> + (source (origin
>>> + (method url-fetch)
>>> + (uri (string-append "https://raw.githubusercontent.com"
>>> + "/nonsequitur/smex/" version "/smex.el"))
>>
>> Hm, I see in some packages you use these "githubusercontent" URLs
>> instead of <https://github.com/nonsequitur/smex/archive/3.0.tar.gz> as
>> we usually do for github. IIUC you did it to avoid extra files
>> (".gitignore", etc.) in the final package directory, right? If so, I
>> think it is not needed, I would still use a link to a tagged source code
>> archive. Moreover I think it's a problem of emacs-build-system that
>> these uninteresting files are not removed.
>>
>> Overall, I don't mind against "githubusercontent", I was just wondering.
>> Actually, I think you found a good way how to pick the needed files to
>> make several packages from a single repo (as you did for
>> "ido-ubiquitous" and "ido-completing-read+").
>
> Yes, I did this to avoid all sorts of unnecessary files making into
> the store, as well as making it more closely mimic the single elisp
> files that were released on MELPA or whatever. These URLs are stable,
> so I thought it had a good clever/useful hack ratio. :)
I think the downside is that the GitHub updater won’t be able to
identify these, although I’m not 100% sure of that.
Anyway, since the URLs are stable, it’s OK.
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-06-03 8:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 14:05 [PATCH 01/10] gnu: Add emacs-smex David Thompson
2016-06-01 14:05 ` [PATCH 02/10] gnu: Add emacs-js2-mode David Thompson
2016-06-01 14:05 ` [PATCH 03/10] gnu: Add emacs-markdown-mode David Thompson
2016-06-01 14:05 ` [PATCH 04/10] gnu: Add emacs-projectile David Thompson
2016-06-01 14:05 ` [PATCH 05/10] gnu: Add emacs-elfeed David Thompson
2016-06-01 14:05 ` [PATCH 06/10] gnu: Add emacs-rainbow-delimiters David Thompson
2016-06-01 14:05 ` [PATCH 07/10] gnu: Add emacs-ido-completing-read+ David Thompson
2016-06-01 14:05 ` [PATCH 08/10] gnu: Add emacs-ido-ubiquitous David Thompson
2016-06-01 14:05 ` [PATCH 09/10] gnu: Add emacs-yaml-mode David Thompson
2016-06-03 15:37 ` Mark H Weaver
2016-06-03 15:44 ` Thompson, David
2016-06-01 14:05 ` [PATCH 10/10] gnu: Add emacs-web-mode David Thompson
2016-06-02 9:26 ` [PATCH 01/10] gnu: Add emacs-smex Alex Kost
2016-06-02 13:33 ` Thompson, David
2016-06-03 8:14 ` Ludovic Courtès [this message]
2016-06-03 12:10 ` Ben Woodcroft
2016-06-05 20:03 ` Ludovic Courtès
2016-06-03 8:16 ` Ludovic Courtès
2016-06-03 12:56 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg8e4rkw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=davet@gnu.org \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.