From: Alex Kost <alezost@gmail.com>
To: John J Foerch <jjfoerch@earthlink.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add di.
Date: Mon, 04 Jul 2016 09:43:55 +0300 [thread overview]
Message-ID: <87eg79kims.fsf@gmail.com> (raw)
In-Reply-To: <87y45i83pi.fsf@hecubus.retroj.net> (John J. Foerch's message of "Sun, 03 Jul 2016 23:47:05 -0400")
John J Foerch (2016-07-04 06:47 +0300) wrote:
> John J Foerch <jjfoerch@earthlink.net> writes:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote:
>>>> * gnu/packages/admin.scm (di): New variable.
>>>
>>> Thanks!
>>>
>>>> + (arguments
>>>> + `(#:phases
>>>> + (modify-phases %standard-phases
>>>> + (delete 'configure)
>>>> + (delete 'check)
>>>
>>> Did you try setting `#:test-target "test"` in the arguments? The
>>> Makefile has a test target.
>>>
>>
>> I didn't know about that. I'll try it out.
>>
> A test relating to an included perl module Filesys::di fails. I hadn't
> intended to include that module in the package, as all I'm interested in
> is the 'di' binary. Given that, I would suggest that we bypass the
> tests.
As for me, I would also disable the tests. All these handmade Makefiles
in all sub-directories are a nightmare. I think trying to figure out
what is needed to run the tests doesn't worth it.
Also don't forget to add a copyright line for yourself in the beginning
of "admin.scm".
--
Alex
next prev parent reply other threads:[~2016-07-04 6:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 19:13 [PATCH] gnu: Add di John J Foerch
2016-07-03 21:02 ` Leo Famulari
2016-07-03 22:03 ` John J Foerch
2016-07-04 3:47 ` John J Foerch
2016-07-04 6:43 ` Alex Kost [this message]
2016-07-04 15:18 ` John J Foerch
2016-07-04 19:07 ` Leo Famulari
2016-07-05 1:53 ` John J Foerch
2016-07-07 16:30 ` John J Foerch
2016-07-07 17:37 ` Leo Famulari
2016-07-08 7:27 ` Alex Kost
2016-07-08 0:40 ` Leo Famulari
2016-07-08 14:06 ` John J Foerch
2016-07-04 19:04 ` Leo Famulari
2016-07-05 1:56 ` John J Foerch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg79kims.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=jjfoerch@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.