From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: gnu/system/u-boot.scm
Date: Thu, 28 Jul 2016 14:26:22 +0200
Message-ID: <87eg6ej6dt.fsf@gnu.org>
References: <20160721223501.3a989d55@scratchpost.org> <877fc815wg.fsf@gnu.org>
	<20160727113248.2ee9087c@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37672)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bSkOW-0000h5-Fs
	for guix-devel@gnu.org; Thu, 28 Jul 2016 08:26:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bSkOQ-0001Dd-N1
	for guix-devel@gnu.org; Thu, 28 Jul 2016 08:26:31 -0400
In-Reply-To: <20160727113248.2ee9087c@scratchpost.org> (Danny Milosavljevic's
	message of "Wed, 27 Jul 2016 11:32:48 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel <guix-devel@gnu.org>

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Tue, 26 Jul 2016 22:49:35 +0200
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> >   (u-boot          u-boot-configuration-u-boot           ; package
>> >                    (default (@ (gnu packages u-boot) (make-u-boot-pack=
age board))))=20=20
>>=20
>> The default value has invalid syntax.  Should be simply:
>>=20
>>   (default (make-u-boot-package board))
>>=20
>> but I think this doesn=E2=80=99t work (=E2=80=98board=E2=80=99 will be u=
nbound; yeah,
>> counter-intuitive.)
>>=20
>> You could instead do (default #f) and call =E2=80=98make-u-boot-package=
=E2=80=99 when
>> that value is #f.
>>=20
>> > (define (eye-candy config root-fs system port)
>> >   "dummy"
>> >   (mlet* %store-monad ((image #f))
>> >     (return (and image
>> >                  #~(format #$port "")))))
>> >=20=20
>>=20
>> Simply remove it.  :-)
>
> Yeah, but there's a=20
>
>   (mlet %store-monad ((sugar (eye-candy config store-fs system #~port)))
>
> in the same file.
>
> Can I remove that and #$sugar , too? Will it still work?

Yes.

> Also, I'm trying to s/grub.cfg/bootloader-configuration-file/g right now,=
 but I wonder
>
> (1) Whether it's possible to determine the basename of the config-file de=
rivation in order to find out what bootloader to install
> (2) Whether we want to do it that way
>
> .
>
> If so, we could have a install-bootloader routine that detects what the f=
ilename of the bootloader-configuration-file object is and then calls eithe=
r install-grub or install-u-boot.

I think we need two separate procedures on the build side:
=E2=80=98install-grub=E2=80=99, and =E2=80=98install-u-boot=E2=80=99.

Choosing between GRUB and U-Boot should happen on the =E2=80=9Chost side=E2=
=80=9D,
mostly likely in (gnu system).

HTH,
Ludo=E2=80=99.