Re: [PATCH] gnu: Add python-pygame.

[Kei Kebreau <kei@openmailbox.org>]

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

Roel Janssen <roel@gnu.org> writes:

> Kei Kebreau writes:
>
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> The python-pygame patch as promised. Note that it requires the
>>> application of the most recently submitted libsmpeg patch. Would anyone
>>> else like to test this? :-)
>
> I've succesfully built both the libsmpeg patch and python-pygame.
>
>> Please disregard the earlier patch. I had to add the other licenses and
>> a description to the definition. Thanks to Roel for sharing a pygame
>> definition!
>
> Thank you for getting it to work!  I only have one comment:
>
>>+               (system* "ln" "--symbolic" "Setup.in" "Setup")))))))
>>+         ;; The default tries to install libraries into the python directory.
>>+         ;; Using --install-lib, we can provide the correct path.
>>+    (native-inputs
>>+     `(("python-setuptools" ,python-setuptools)))
>
> The comment seems to be out of place.  I don't even know where it
> belongs to anymore.  Was this for another build phase customization? (it
> seems to because of the indentation..).
>
> Thank you.
>
> Kind regards,
> Roel Janssen

Indeed, that comment was left over from the install phase you replaced
when you used the gnu-build-system. I'll correct it before I push the
changes upstream. Unless anyone else has any input, I'll be pushing this
later today!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]