From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Linux kernel Date: Sat, 10 Sep 2016 00:26:59 +0200 Message-ID: <87eg4sr9os.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biUGK-00072v-PT for guix-devel@gnu.org; Fri, 09 Sep 2016 18:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biUGF-0004ox-LX for guix-devel@gnu.org; Fri, 09 Sep 2016 18:27:07 -0400 In-Reply-To: (David Craven's message of "Fri, 9 Sep 2016 00:45:13 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel David Craven skribis: > I reworked the patches for the linux-libre package and made some other > improvements that make customizing the linux-libre package easier. I > tested that everything builds and that there wasn't any breakage on > x86_64, but testing the arm kernel on real hardware is a wip. Is it > easier if I push a branch? They're 17 small patches. > > 86fb6ee gnu: Add linux-libre-beagle-bone-black. > 70d7e6d gnu: Add linux-libre-multi-v7. > 8073e6e gnu: make-linux-libre: Add supported-systems option. > 6be1f44 gnu: linux-libre: Use kmod. > dd9be2e gnu: make-linux-libre: Add zImage to output. > c4772da gnu: linux-libre: Add extra-version option. > 089b957 gnu: linux-libre: Add make-linux-libre-source. > 5508f0d gnu: Add u-boot-beagle-bone-black. > db2fc94 gnu: dtc: Remove patch-paths phase. > 01c8d0a gnu: linux-libre: Add additional-configuration to make-linux-libr= e. > 9ccf388 gnu: linux-libre: Use make-linux-libre. > 86126ae gnu: linux-libre: Add support for cross-compilation. > 2ef150b gnu: linux-libre: Move kernel configuration to configure phase. > 4737e87 gnu: linux-libre: Apply %boot-logo patch in origin. > c55b169 gnu: linux-libre: Use system->architecture. > c456362 gnu: linux-libre: Use modify-phases. > 95fe35a gnu: module-init-tools: Prevent line wrapping. Seems we already discussed some of these, no? Anyway, I=E2=80=99m fine with you sending the remaining patches with =E2=80= =98git send-email=E2=80=99; it makes it easier to comment on the code for me. > The interesting parts are shown here: > > (define* (make-linux-libre version source supported-systems > #:key > (extra-version #f) > (configuration-file #f) > (defconfig "defconfig") > (additional-configuration > %default-additional-kernel-configuration)) > (package > (name (if extra-version > (string-append "linux-libre-" extra-version) > "linux-libre")) > > > (define-public linux-libre > (let* ((version "4.7.2") > (hash "1rp09y2hv0hvdybm2n2im9717kzxmklpgzs8k1bmdfzqxyg8cb85") ^ Nitpick: Use =E2=80=98base32=E2=80=99 here, rather than in the callee (that= way, base32 parsing happens at compile time and errors are detected early.) Ludo=E2=80=99.