From: Kei Kebreau <kei@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add schismtracker.
Date: Sun, 11 Sep 2016 09:38:20 -0400 [thread overview]
Message-ID: <87eg4qeeur.fsf@openmailbox.org> (raw)
In-Reply-To: <87mvjfg74n.fsf@openmailbox.org> (Kei Kebreau's message of "Sat, 10 Sep 2016 10:30:00 -0400")
[-- Attachment #1.1: Type: text/plain, Size: 1136 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Kei Kebreau <kei@openmailbox.org> writes:
>
> [...]
>
>>> + (home-page "http://schismtracker.org")
>>> + (synopsis "Impulse Tracker clone")
>>
>> I think this should be more generic. The tagline from github works
>> pretty well: "Oldschool sample-based music composition tool".
>
> +1
>
>> The rest LGTM. But! The package records build time in version.c. I
>> managed to make it reproducible by adding a phase like this:
>>
>> (add-before 'build 'make-reproducible
>> (lambda _
>> ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>> (substitute* "schism/version.c"
>> (("Schism Tracker built %s %s.*$")
>> (string-append "Schism Tracker version " ,version "\");")))
>> #t))
>
> I would suggest making it a ‘snippet’ instead, as we usually do in
> such
> cases.
>
> Thanks Kei & Marius!
>
> Ludo’.
I think I got everything... Will this do?
*Forgot to cc the mailing list last time! :P
[-- Attachment #1.2: 0001-gnu-Add-schismtracker.patch --]
[-- Type: text/plain, Size: 2780 bytes --]
From 961dcf1e1e3ce45ea9d3f9c84fbe5562d52a1dd4 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sat, 10 Sep 2016 10:27:34 -0400
Subject: [PATCH] gnu: Add schismtracker.
* gnu/packages/music.scm (schismtracker): New variable.
---
gnu/packages/music.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 88743aa..f294564 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1638,6 +1638,52 @@ for improved Amiga ProTracker 2/3 compatibility.")
;; 'src/milkyplay' is under Modified BSD, the rest is under GPL3 or later.
(license (list license:bsd-3 license:gpl3+))))
+(define-public schismtracker
+ (package
+ (name "schismtracker")
+ (version "20160521")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/" name "/" name "/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0c6r24wm3rldm4j8cskl9xnixj3rwi3lnrhckw5gv43wpy6h4jcz"))
+ (modules '((guix build utils)))
+ (snippet
+ ;; Remove use of __DATE__ and __TIME__ for reproducibility.
+ `(substitute* "schism/version.c"
+ (("Schism Tracker build %s %s.*$")
+ (string-append "Schism Tracker version " ,version "\");"))))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'autoconf
+ (lambda _ (zero? (system* "autoreconf" "-vfi"))))
+ (add-before 'configure 'link-libm
+ (lambda _ (setenv "LIBS" "-lm") #t)))))
+ (native-inputs
+ `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("python" ,python)))
+ (inputs
+ `(("alsa-lib" ,alsa-lib) ; for asound dependency
+ ("libx11" ,libx11)
+ ("libxext" ,libxext)
+ ("sdl" ,sdl)))
+ (home-page "http://schismtracker.org")
+ (synopsis "Oldschool sample-based music composition tool")
+ (description
+ "Schism Tracker is a reimplementation of Impulse Tracker, a program used to
+create high quality music without the requirements of specialized, expensive
+equipment, and with a unique \"finger feel\" that is difficult to replicate in
+part. The player is based on a highly modified version of the ModPlug engine,
+with a number of bugfixes and changes to improve IT playback.")
+ (license license:gpl2+)))
+
(define-public moc
(package
(name "moc")
--
2.10.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-09-11 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 22:19 [PATCH] gnu: Add schismtracker Kei Kebreau
2016-09-10 7:34 ` Marius Bakke
2016-09-10 12:55 ` Ludovic Courtès
[not found] ` <87mvjfg74n.fsf@openmailbox.org>
2016-09-11 13:38 ` Kei Kebreau [this message]
2016-09-13 11:50 ` Ludovic Courtès
2016-09-13 14:33 ` Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg4qeeur.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.