From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add nfs-utils
Date: Mon, 12 Sep 2016 15:37:53 +0200
Message-ID: <87eg4ptf0u.fsf@gnu.org>
References: <1473279653-23139-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40601)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjRQx-0007tQ-Tp
	for guix-devel@gnu.org; Mon, 12 Sep 2016 09:38:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjRQr-00052I-VU
	for guix-devel@gnu.org; Mon, 12 Sep 2016 09:38:02 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36279)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1bjRQr-00051t-TD
	for guix-devel@gnu.org; Mon, 12 Sep 2016 09:37:57 -0400
In-Reply-To: <1473279653-23139-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Wed, 7 Sep 2016 22:20:53 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/linux.scm (nfs-utils): New variable.

(gnu packages linux) was meant for things that use non-portable
interfaces of the kernel Linux.  I don=E2=80=99t think that is the case her=
e?

So maybe this should go to (gnu packages onc-rpc) or (gnu packages nfs).

> +       #:phases (modify-phases %standard-phases
> +                  (add-before
> +                      'configure 'mutate-source

Move to line above.

Maybe =E2=80=98adjust-command-file-names=E2=80=99 would be more descriptive=
 a phase
name?

> +                    (lambda _
> +                      ;; Eventually, we should provide our own start-sta=
td
> +                      ;; script instead ... one which starts the rpc.sta=
td
> +                      ;; service (which we don't yet have)
> +                      (substitute* `("utils/statd/start-statd")
> +                        (("^PATH=3D.*") "")
> +                        (("^flock")
> +                         (string-append
> +                          (assoc-ref %build-inputs "util-linux")
> +                          "/bin/flock"))
> +                        (("^exec rpc.statd")
> +                         (string-append "exec "
> +                          (assoc-ref %outputs "out") "/sbin/rpc.statd")))

I think the comment should probably mention something like =E2=80=9CRemove =
FHS
assumptions from the 'start-statd' script.=E2=80=9D  The bit about the need=
 for
a service is not really relevant here, IMO.

Please punctuate sentences too.  :-)

> +    ;; It is hard to be sure what the licence is.  Most of the source fi=
les
> +    ;; contain no licence notice at all.  A few have a licence notice fo=
r a 3
> +    ;; clause non-copyleft licence.  However the tarball has a COPYING f=
ile
> +    ;; with the text of GPLv2 -- It seems then that GLPv2 is the most
> +    ;; restrictive licence, and until advice to the contrary we must ass=
ume
> +    ;; that is what is intended.
> +    (license license:gpl2)))

I think this should be gpl2+ unless the =E2=80=9Cor later version=E2=80=9D =
wording has
been explicitly removed.

OK with these changes, thanks!

Ludo=E2=80=99.