From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 07/07: guix: python-build-system: Fix an outdated comment.
Date: Thu, 13 Oct 2016 15:32:09 -0400
Message-ID: <87eg3kyrie.fsf@netris.org>
References: <20161013152324.1276.70078@vcs.savannah.gnu.org>
	<20161013152324.EF9C7220170@vcs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bull6-0006In-4e
	for guix-devel@gnu.org; Thu, 13 Oct 2016 15:33:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bull1-0000jt-4p
	for guix-devel@gnu.org; Thu, 13 Oct 2016 15:33:39 -0400
Received: from world.peace.net ([50.252.239.5]:38531)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bull1-0000hE-0W
	for guix-devel@gnu.org; Thu, 13 Oct 2016 15:33:35 -0400
In-Reply-To: <20161013152324.EF9C7220170@vcs.savannah.gnu.org> (Hartmut
	Goebel's message of "Thu, 13 Oct 2016 15:23:24 +0000 (UTC)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

h.goebel@crazy-compilers.com (Hartmut Goebel) writes:

> htgoebel pushed a commit to branch master
> in repository guix.
>
> commit 635a7af45d6e2105ad65d1a9531126cc232a2a50
> Author: Hartmut Goebel <h.goebel@crazy-compilers.com>
> Date:   Sun Oct 2 18:48:56 2016 +0200
>
>     guix: python-build-system: Fix an outdated comment.
>     
>     The python-build-system uses phases the build and install, but not
>     configure. So the old comment was plain wrong since Sept. 2013, when the build
>     phase has been added.
> ---
>  guix/build/python-build-system.scm |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 9109fb4..e906e60 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -137,8 +137,7 @@ installed with setuptools."
>      #t))
>  
>  (define %standard-phases
> -  ;; 'configure' and 'build' phases are not needed.  Everything is done during
> -  ;; 'install'.
> +  ;; 'configure' phase is not needed.
>    (modify-phases gnu:%standard-phases
>      (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980)
>      (delete 'configure)

This change triggered over 6300 rebuilds on 'master'.  I reverted it.
Please beware that changing some files in guix/build/*.scm can trigger a
large number of rebuilds, because some of these files are implicitly
used as inputs to a large number of builds.

    Regards,
      Mark