From: Mark H Weaver <mhw@netris.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: 07/07: guix: python-build-system: Fix an outdated comment.
Date: Thu, 13 Oct 2016 15:32:09 -0400 [thread overview]
Message-ID: <87eg3kyrie.fsf@netris.org> (raw)
In-Reply-To: <20161013152324.EF9C7220170@vcs.savannah.gnu.org> (Hartmut Goebel's message of "Thu, 13 Oct 2016 15:23:24 +0000 (UTC)")
h.goebel@crazy-compilers.com (Hartmut Goebel) writes:
> htgoebel pushed a commit to branch master
> in repository guix.
>
> commit 635a7af45d6e2105ad65d1a9531126cc232a2a50
> Author: Hartmut Goebel <h.goebel@crazy-compilers.com>
> Date: Sun Oct 2 18:48:56 2016 +0200
>
> guix: python-build-system: Fix an outdated comment.
>
> The python-build-system uses phases the build and install, but not
> configure. So the old comment was plain wrong since Sept. 2013, when the build
> phase has been added.
> ---
> guix/build/python-build-system.scm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 9109fb4..e906e60 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -137,8 +137,7 @@ installed with setuptools."
> #t))
>
> (define %standard-phases
> - ;; 'configure' and 'build' phases are not needed. Everything is done during
> - ;; 'install'.
> + ;; 'configure' phase is not needed.
> (modify-phases gnu:%standard-phases
> (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980)
> (delete 'configure)
This change triggered over 6300 rebuilds on 'master'. I reverted it.
Please beware that changing some files in guix/build/*.scm can trigger a
large number of rebuilds, because some of these files are implicitly
used as inputs to a large number of builds.
Regards,
Mark
next parent reply other threads:[~2016-10-13 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161013152324.1276.70078@vcs.savannah.gnu.org>
[not found] ` <20161013152324.EF9C7220170@vcs.savannah.gnu.org>
2016-10-13 19:32 ` Mark H Weaver [this message]
2016-10-13 19:39 ` 07/07: guix: python-build-system: Fix an outdated comment Leo Famulari
2016-10-13 20:45 ` Danny Milosavljevic
2016-10-15 22:16 ` Ludovic Courtès
2016-10-14 7:55 ` Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg3kyrie.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.