From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: fftw: Build threads library.
Date: Tue, 15 Nov 2016 21:36:06 +0100 [thread overview]
Message-ID: <87eg2c5vm1.fsf@elephly.net> (raw)
In-Reply-To: <87lgwlf3ug.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
>> configure flags.
>> ---
>> gnu/packages/algebra.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
>> index 8e9695d..e212775 100644
>> --- a/gnu/packages/algebra.scm
>> +++ b/gnu/packages/algebra.scm
>> @@ -544,7 +544,8 @@ a C program.")
>> "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
>> (build-system gnu-build-system)
>> (arguments
>> - '(#:configure-flags '("--enable-shared" "--enable-openmp")
>> + '(#:configure-flags
>> + '("--enable-shared" "--enable-openmp" "--enable-threads")
>> #:phases (alist-cons-before
>> 'build 'no-native
>> (lambda _
>
> LGTM!
>
> Per
> <https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
> this is a perfect candidate for ‘staging’.
Thanks for the reference. We don’t have a staging branch yet, as far as
I can tell. May I just push this commit to a new “staging” branch then?
> (In the meantime, if that helps, you could additionally create an FFTW
> variant for use by Ardour, in master.)
Yes, I’ll do that.
~~ Ricardo
next prev parent reply other threads:[~2016-11-15 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 22:43 [PATCH] Fix ardour and mod-host builds Ricardo Wurmus
2016-11-14 22:43 ` [PATCH] gnu: fftw: Build threads library Ricardo Wurmus
2016-11-15 10:13 ` Ludovic Courtès
2016-11-15 20:36 ` Ricardo Wurmus [this message]
2016-11-16 21:23 ` Ludovic Courtès
2016-11-15 8:03 ` [PATCH] Fix ardour and mod-host builds Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg2c5vm1.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.