From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add kakoune
Date: Thu, 26 Jan 2017 11:20:17 +0100
Message-ID: <87efzq3yxq.fsf@gnu.org>
References: <87zijekrns.fsf@zancanaro.id.au> <87y3yykov6.fsf@zancanaro.id.au>
	<20161230192556.GA2668@jasmine> <87wpehkns6.fsf@zancanaro.id.au>
	<20170110222611.GA8431@jasmine> <87vat9uqqd.fsf@zancanaro.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cWhAH-0002nX-FD
	for guix-devel@gnu.org; Thu, 26 Jan 2017 05:20:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cWhAC-0006X8-Hf
	for guix-devel@gnu.org; Thu, 26 Jan 2017 05:20:25 -0500
In-Reply-To: <87vat9uqqd.fsf@zancanaro.id.au> (Carlo Zancanaro's message of
	"Sat, 21 Jan 2017 12:49:30 +1100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Carlo Zancanaro <carlo@zancanaro.id.au>
Cc: guix-devel <guix-devel@gnu.org>

Hello,

Sorry for the delay.

Carlo Zancanaro <carlo@zancanaro.id.au> skribis:

> From a15396f186d5a88f7fbe1af21add9bbd40ddc59b Mon Sep 17 00:00:00 2001
> From: Carlo Zancanaro <carlo@zancanaro.id.au>
> Date: Fri, 30 Dec 2016 02:15:59 +1100
> Subject: [PATCH] gnu: Add kakoune
>
> * gnu/packages/patches/kakoune-leave-manpages-uncompressed.patch: New fil=
e.
> * gnu/local.mk (dist_patch_DATA): Register patch.
> * gnu/packages/text-editors.scm (kakoune): New variable.

[...]

> +++ b/gnu/packages/patches/kakoune-leave-manpages-uncompressed.patch
> @@ -0,0 +1,69 @@
> +Kakoune compresses its manpages, which makes the build non-reproducible =
(as it
> +leaves timestamps in files). If we don't do that here, and instead do it=
 in
> +the guix phases `compress-manpages` then the build is reproducible.
> +
> +--- a/src/Makefile
> ++++ b/src/Makefile
> +@@ -22,7 +22,7 @@
> + objects :=3D $(addprefix ., $(sources:.cc=3D$(suffix).o))
> + deps :=3D $(addprefix ., $(sources:.cc=3D$(suffix).d))
> + docs :=3D $(wildcard ../doc/manpages/*.asciidoc)
> +-mandocs :=3D $(docs:.asciidoc=3D.gz)
> ++mandocs :=3D $(docs:.asciidoc=3D.1)
> +=20
> + PREFIX ?=3D /usr/local
> + DESTDIR ?=3D # root dir
> +@@ -76,19 +76,17 @@
> + 	$(CXX) $(CPPFLAGS) $(CXXFLAGS) -MD -MP -MF $(addprefix ., $(<:.cc=3D$(=
suffix).d)) -c -o $@ $<
> +=20
> + # Generate the man page
> +-../doc/kak.1.gz: ../doc/kak.1.txt
> ++../doc/kak.1: ../doc/kak.1.txt
> + 	a2x --no-xmllint -f manpage $<
> +-	gzip -f $(basename $<)

It=E2=80=99s simpler to add --no-name (which suppresses timestamps and file
names from the gzip output) to all the gzip invocation in this Makefile.

Could you do that?

In =E2=80=98core-updates=E2=80=99 I=E2=80=99d like to add a phase that clea=
rs timestamps and
file names from all gzip headers so we don=E2=80=99t have to bother.

Thanks!

Ludo=E2=80=99.