From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxqpO-0005Qc-BX for guix-patches@gnu.org; Tue, 11 Apr 2017 04:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxqpK-000347-56 for guix-patches@gnu.org; Tue, 11 Apr 2017 04:07:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxqpK-00033x-1y for guix-patches@gnu.org; Tue, 11 Apr 2017 04:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cxqpJ-0004ld-MD for guix-patches@gnu.org; Tue, 11 Apr 2017 04:07:01 -0400 Subject: bug#26425: [PATCH 1/2] gnu: Add python-poppler-qt5. Resent-Message-ID: References: <20170409204753.24456-1-rekado@elephly.net> <871st0hbhk.fsf@gnu.org> From: Ricardo Wurmus In-reply-to: <871st0hbhk.fsf@gnu.org> Date: Tue, 11 Apr 2017 10:06:21 +0200 Message-ID: <87efwzqsg2.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26425@debbugs.gnu.org Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> * gnu/packages/pdf.scm (python-poppler-qt5): New variable. > > LGTM! > >> + (substitute* "setup.py" >> + ;; This check always fails, so disable it. >> + (("if not check_qtxml\\(\\)") >> + "if True") > > The check fails wrongfully? Yes. We do provide qtxml with qtbase. It’s easier to disable this check than to fix it, given that we know that we have qtxml. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net