From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42871)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dALe6-0007Gq-Vw
	for guix-patches@gnu.org; Mon, 15 May 2017 15:27:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dALe2-0008FF-3K
	for guix-patches@gnu.org; Mon, 15 May 2017 15:27:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44244)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dALe1-0008Et-V7
	for guix-patches@gnu.org; Mon, 15 May 2017 15:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dALe1-0006Ow-Ms
	for guix-patches@gnu.org; Mon, 15 May 2017 15:27:01 -0400
Subject: bug#26940: [PATCH 1/3] gnu: Add http-parser.
Resent-Message-ID: <handler.26940.B26940.149487638724564@debbugs.gnu.org>
References: <87fug6w7ba.fsf@elephly.net>
	<20170515140122.26545-1-rekado@elephly.net>
	<87inl2dnlg.fsf@fastmail.com>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87inl2dnlg.fsf@fastmail.com>
Date: Mon, 15 May 2017 21:26:09 +0200
Message-ID: <87efvp7wha.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26940@debbugs.gnu.org


Marius Bakke <mbakke@fastmail.com> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/web.scm (http-parser): New variable.
>
> [...]
>
>> +    (description "This is a parser for HTTP messages written in C.  It parses
>> +both requests and responses. The parser is designed to be used in performance
>> +HTTP applications. It does not make any syscalls nor allocations, it does not
>> +buffer data, it can be interrupted at anytime. Depending on your architecture,
>> +it only requires about 40 bytes of data per message stream (in a web server
>> +that is per connection).")
>
> Some missing spaces in the description here. The sentences also read a
> bit weird, should it be "high-performance HTTP applications"? Or
> performant? Maybe just "fast"? LGTM with cosmetic fix.

Thanks for the suggestions!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net