From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dANRP-0001s0-SI for guix-patches@gnu.org; Mon, 15 May 2017 17:22:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dANRK-0003gp-Vo for guix-patches@gnu.org; Mon, 15 May 2017 17:22:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dANRK-0003gg-SO for guix-patches@gnu.org; Mon, 15 May 2017 17:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dANRK-0000cl-N6 for guix-patches@gnu.org; Mon, 15 May 2017 17:22:02 -0400 Subject: bug#26487: Add antlr3 Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <20170413224513.342184b2@lepiller.eu> <87h91pmoh6.fsf@openmailbox.org> <20170417150349.7040ec6c@lepiller.eu> From: Ricardo Wurmus In-reply-to: <20170417150349.7040ec6c@lepiller.eu> Date: Mon, 15 May 2017 23:21:25 +0200 Message-ID: <87efvp6ckq.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 26487-done@debbugs.gnu.org Hi Julien, thank you for tackling antlr! I saw that the patches have already been pushed, but here are a couple of comments anyway. * Please end all phases and snippets with “#t” or use (zero? …) when the last thing is “system*”. * All Java packages should be prefixed with “java-”. * Please capitalise “Java” in descriptions. * When disabling tests, please always explain why. * Instead of copying from the ant-build-system you can reference build phases directly. * Please use “with-directory-excursion” instead of multiple calls to “chdir” when possible. * Please put comments before package variants that use a seemingly arbitrary version or configuration. I’m going to make a couple of changes to your packages in the coming days as follow-up commits to address these issues. Thanks again! (Since the patches have been pushed already, I’m closing this bug.) -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net