From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/01: gnu: glibc/linux: Add patches for CVE-2017-1000366. Date: Sat, 01 Jul 2017 13:03:10 -0400 Message-ID: <87efu0nl81.fsf@netris.org> References: <20170629200450.17825.10767@vcs0.savannah.gnu.org> <20170629200450.E946620FFF@vcs0.savannah.gnu.org> <87k23tpk4d.fsf@netris.org> <87h8ywb12p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRLo2-0005Dw-Nv for guix-devel@gnu.org; Sat, 01 Jul 2017 13:03:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRLnx-0004Sz-Qy for guix-devel@gnu.org; Sat, 01 Jul 2017 13:03:38 -0400 In-Reply-To: <87h8ywb12p.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 01 Jul 2017 17:59:10 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mark H Weaver skribis: > >> More generally, I think we need to give more thought to how to handle >> 'replacement' fields when we inherit packages, in order to do the right >> thing when the inherited package is grafted. One way is to override >> (replacement #f). Another is to use the 'package/inherit' macro from >> (guix packages), which applies the same overrides to the replacement. >> I can't think of a case where it's proper to leave the 'replacement' >> unchanged when inheriting a package. >> >> What do you think? > > First, we could mark the =E2=80=98replacement=E2=80=99 field as =E2=80=9C= innate=E2=80=9D, which means it > will never be inherited (like the =E2=80=98location=E2=80=99 field.) Lik= e you, I can=E2=80=99t > think of a situation where inheriting the replacement makes sense. > > Then =E2=80=98package/inherit=E2=80=99 seems to be doing the rest of the = job correctly. > The bad thing is that it=E2=80=99s easy to forget to use it. If we=E2=80= =99re > motivated, we could hack this feature (let=E2=80=99s call it =E2=80=9Crec= ursive > inheritance=E2=80=9D) right into (guix records). > > Thoughts? I've considered this, but I see a problem: when creating the replacement package itself, e.g. 'glibc-2.25-patched' on the 'master' branch, we need to inherit from the original package and *discard* the replacement. If we used 'package/inherit' there, it would lead to an infinite series of replacements. It still might make sense to hack 'package/inherit' into (guix records) as the default behavior, but then we would need a separate mechanism for creating replacements. What do you think? Mark