From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dzkv1-0007gX-ML
	for guix-patches@gnu.org; Wed, 04 Oct 2017 10:45:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dzkv0-00088u-Pe
	for guix-patches@gnu.org; Wed, 04 Oct 2017 10:45:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40337)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dzkv0-00088Z-MD
	for guix-patches@gnu.org; Wed, 04 Oct 2017 10:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dzkuz-0000DI-Ua
	for guix-patches@gnu.org; Wed, 04 Oct 2017 10:45:02 -0400
Subject: [bug#28198] [PATCH 3/3] services: Add MongoDB.
Resent-Message-ID: <handler.28198.B28198.1507128274771@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170930075942.31332-1-mail@cbaines.net>
	<20170930075942.31332-3-mail@cbaines.net>
Date: Wed, 04 Oct 2017 16:44:21 +0200
In-Reply-To: <20170930075942.31332-3-mail@cbaines.net> (Christopher Baines's
	message of "Sat, 30 Sep 2017 08:59:42 +0100")
Message-ID: <87efqj6khm.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 28198@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/services/databases.scm (%default-mongodb-configuration-file,
>   %mongodb-accounts, mongodb-service-type): New variables.
>   (<mongodb-configuration>): New record type.
>   (mongodb-activation, mongodb-shepherd-service): New procedures.
> * gnu/tests/databases.scm (%test-mongodb): New variable.
> * doc/guix.text (Database Services): Add MongoDB documentation.
                ^

texi :-)

[...]

> +(define mongodb-service-type
> +  (service-type
> +   (name 'mongodb)
> +   (extensions
> +    (list (service-extension shepherd-root-service-type
> +                             (compose list
> +                                      mongodb-shepherd-service))
> +          (service-extension activation-service-type
> +                             mongodb-activation)
> +          (service-extension account-service-type
> +                             (const %mongodb-accounts))))
> +   (default-value
> +     (mongodb-configuration))))

Could you add a =E2=80=98description=E2=80=99 field?  :-)

Like =E2=80=9CRun the MongoDB document database server.=E2=80=9D

Apart from that it looks great.

Thank you!

Ludo=E2=80=99.