From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4DbG-0000Id-7Q for guix-patches@gnu.org; Mon, 16 Oct 2017 18:11:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4DbC-0004Bw-W1 for guix-patches@gnu.org; Mon, 16 Oct 2017 18:11:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4DbC-0004Bm-SO for guix-patches@gnu.org; Mon, 16 Oct 2017 18:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e4DbC-0007Vx-Hf for guix-patches@gnu.org; Mon, 16 Oct 2017 18:11:02 -0400 Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-Message-ID: From: Marius Bakke In-Reply-To: <87shejmbml.fsf@fsfe.org> References: <87zibw4oen.fsf@fastmail.com> <87tvyzcjmg.fsf@gnu.org> <87shejmbml.fsf@fsfe.org> Date: Tue, 17 Oct 2017 00:09:56 +0200 Message-ID: <87efq27nij.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jelle Licht , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27791@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jelle Licht writes: > Ludovic Court=C3=A8s writes: > >> Hi Jelle, >> >> Is anything holding this back? >> >> https://bugs.gnu.org/27791 > > It just fell through the cracks, thanks for reminding me :-). > I still needed to address some of Marius' concerns though... > >> >> TIA! :-) >> >> Ludo=E2=80=99. >> >> Marius Bakke skribis: >> >>> Hi Jelle, >>> >>> Jelle Licht writes: >>> >>>> Hello guix, >>>> >>>> Attached is a patch to include passmenu, a dmenu interface to the pass >>>> password store. >>>> >>>> I was not quite sure how to structure this patch, as it basically inst= alls >>>> and wraps a shell script from the `password-store' sources. We could >>>> instead include it as a separate output of our `password-store' packag= e, >>>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not e= ven >>>> sure if that approach was in general preferable. >>> >>> I don't think wrapping it with dmenu in PATH is necessary. Users of this >>> script are expected to have dmenu from before, and may want to use >>> another implementation (e.g. rofi), another version, etc. > > While I agree with your general thoughts, wasn't guix supposed to > prevent this ad-hoc mishmash of software? If someone wants to use > another implementation (e.g. rofi), they could just create their own > package that inherits from `password-store' and overrides the "dmenu" > input. Case in point, I am not currently a user of dmenu (besides > indirectly through the passmenu script). In the "rofi" case it would be overriding dmenu and providing some extra command-line arguments, but overall I agree with you and don't really have a strong opinion. To my knowledge there is no established policy for when to allow "impurities" (aka unqualified paths), but optional dependencies often get a free pass. I'm happy either way, so do what you think is best :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlnlLjUACgkQoqBt8qM6 VPpIoQf9F3Wb2X/gS1dQ/Uq/QiQS1IS3n0NcAfTHW29+P+moAp2c/pQFbkQB/o/A hJoX/+brzhLV+U096cfBcpWwWLxydWhyWhiGej40TZ2JZETZk1/oqCQYUrV2D5U9 g2Kz44XlWdQaUA6qnn88har69QG5bKRwKlTqeFolPhh00VGFaiXxHyVWps9GPtIx TxrpK3GLmmVUrLqZy0O2IOl+EGvajEKKwnhF8fnqdMhzCrLEaUk7cvEjUc9nKLdj o0Qnw2UowjkgsEKvHF4cnRIJtJRXTjoW+H41cy753ilksQi6KM9oYDitff2RUKc4 vtF8KmcblVLlHPDDncUy4iZqYfZRLw== =WFwq -----END PGP SIGNATURE----- --=-=-=--