From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4v9H-0005bC-HT for guix-patches@gnu.org; Wed, 18 Oct 2017 16:41:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4v9D-0000qI-JH for guix-patches@gnu.org; Wed, 18 Oct 2017 16:41:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4v9D-0000q8-Cp for guix-patches@gnu.org; Wed, 18 Oct 2017 16:41:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e4v9B-00065W-SG for guix-patches@gnu.org; Wed, 18 Oct 2017 16:41:03 -0400 Subject: [bug#28841] [PATCH 01/24] gnu: Add java-hdrhistogram. Resent-Message-ID: References: <20171014233216.49c852f7@lepiller.eu> <20171014222349.12902-1-julien@lepiller.eu> From: Ricardo Wurmus In-reply-to: <20171014222349.12902-1-julien@lepiller.eu> Date: Wed, 18 Oct 2017 22:40:07 +0200 Message-ID: <87efq042c8.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: julien@lepiller.eu Cc: 28841@debbugs.gnu.org Hi Julien, > From: Julien Lepiller > > * gnu/packages/java.scm (java-hdrhistogram): New variable. […] > + (add-before 'configure 'set-version > + (lambda _ > + (let* ((version-java "src/main/java/org/HdrHistogram/Version.java") > + (template (string-append version-java ".template"))) > + (copy-file template version-java) > + (substitute* version-java > + (("\\$VERSION\\$") ,version) > + (("\\$BUILD_TIME\\$") "0")))))))) Please end the phase with #t. > + (native-inputs > + `(("junit" ,java-junit) > + ("hamcrest" ,java-hamcrest-core))) > + (home-page "https://hdrhistogram.github.io/HdrHistogram") > + (synopsis "High Dynamic Range Histogram") Please use lower case here. > + (description "Histogram that supports recording and analyzing sampled data > +value counts across a configurable integer value range with configurable value > +precision within the range. Value precision is expressed as the number of > +significant digits in the value recording, and provides control over value > +quantization behavior across the value range and the subsequent value resolution > +at any given level.") The first fragment is not a full sentence. Could you please change it? > + (license license:bsd-2))) The website says: --8<---------------cut here---------------start------------->8--- HdrHistogram was originally authored by Gil Tene (@giltene) (Java) and placed in the public domain, as explained at http://creativecommons.org/publicdomain/zero/1.0 --8<---------------cut here---------------end--------------->8--- Does this not apply to this version? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net