From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix
	build compile).
Date: Sun, 22 Oct 2017 17:22:37 -0400
Message-ID: <87efpu5142.fsf@gmail.com>
References: <87poamv2i7.fsf@gnu.org> <20171020160557.27096-1-ludo@gnu.org>
	<20171020160557.27096-2-ludo@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33032)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6Ni5-0003S9-8l
	for bug-guix@gnu.org; Sun, 22 Oct 2017 17:23:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6Ni2-00089I-3n
	for bug-guix@gnu.org; Sun, 22 Oct 2017 17:23:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47622)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e6Ni2-00089E-0C
	for bug-guix@gnu.org; Sun, 22 Oct 2017 17:23:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27284.B27284.150870736821649@debbugs.gnu.org>
In-Reply-To: <20171020160557.27096-2-ludo@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Cou\?\= \=\?utf-8\?Q\?rt\=C3\=A8s\=22's\?\=
	message of "Fri, 20 Oct 2017 18:05:50 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 27284@debbugs.gnu.org

Hello,

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> * guix/build/compile.scm: New file.
> * Makefile.am (MODULES): Add it.
> * build-aux/compile-all.scm: Use it.
> (warnings, file->module, load-module-file)
> (%default-optimizations, %lightweight-optimizations)
> (optimization-options, compile-file*): Remove.
> <top level>: Use 'compile-files'.
> * guix/build/pull.scm (%default-optimizations)
> (%lightweight-optimizations, optimization-options): Remove.
> (build-guix): Rewrite as a call to 'compile-files'.
> * guix/discovery.scm (file-name->module-name): Export.
> ---
>  Makefile.am               |   1 +
>  build-aux/compile-all.scm |  92 ++++----------------------
>  guix/build/compile.scm    | 165 ++++++++++++++++++++++++++++++++++++++++=
++++++
>  guix/build/pull.scm       | 105 ++++++++---------------------
>  guix/discovery.scm        |   4 +-
>  5 files changed, 209 insertions(+), 158 deletions(-)
>  create mode 100644 guix/build/compile.scm

[...]

This and the other patches in this series look fine to me. Maybe the
change log items could be a bit more precise about what got moved rather
than removed, but given the amount of refactoring this might be too
verbose to be worth it?

Maxim