From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: bug#29992: [PATCH] services: postgresql: Use pg_ctl to start and stop
	postgres.
Date: Thu, 25 Jan 2018 15:56:38 +0100
Message-ID: <87efme9ec9.fsf@lassieur.org>
References: <87d11zxpqp.fsf@gnu.org>
	<20180125132002.12953-1-clement@lassieur.org> <87o9liuigk.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eeixx-0005qZ-F0
	for bug-guix@gnu.org; Thu, 25 Jan 2018 09:57:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eeixb-0002tg-Hi
	for bug-guix@gnu.org; Thu, 25 Jan 2018 09:57:25 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:34812)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eeixb-0002tH-9O
	for bug-guix@gnu.org; Thu, 25 Jan 2018 09:57:03 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org,
	clement@lassieur.org (=?UTF-8?Q?Cl=C3=A9ment?= Lassieur)
Resent-Message-ID: <handler.29992.D29992.15168922025417.done@debbugs.gnu.org>
In-reply-to: <87o9liuigk.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 29992-done@debbugs.gnu.org

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Clément Lassieur <clement@lassieur.org> skribis:
>
>> Fixes <https://bugs.gnu.org/29992>.
>>
>> * gnu/services/databases.scm (postgresql-shepherd-service): Replace
>> make-forkexec-constructor and make-kill-destructor with pg_ctl.
>
> LGTM, thanks!

Pushed as 5ee4cd69c47b77e534654a130b1264ad05809943.

> In the future we should add a postgresql service test, perhaps it could
> share code with the mysql test in (gnu tests databases).

Uh-huh I was scared that you would ask this!  I'll add it to my todo
list then. :-)