From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev9Pp-0001tk-IC for guix-patches@gnu.org; Sun, 11 Mar 2018 18:26:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ev9Pm-0004IX-C2 for guix-patches@gnu.org; Sun, 11 Mar 2018 18:26:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ev9Pm-0004IM-8O for guix-patches@gnu.org; Sun, 11 Mar 2018 18:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ev9Pm-0000Q4-1b for guix-patches@gnu.org; Sun, 11 Mar 2018 18:26:02 -0400 Subject: [bug#30761] [PATCH staging 5/9] build-system/meson: Skip the 'fix-runpath' phase on armhf. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180309181108.22888-1-mbakke@fastmail.com> <20180309181108.22888-5-mbakke@fastmail.com> Date: Sun, 11 Mar 2018 23:24:57 +0100 In-Reply-To: <20180309181108.22888-5-mbakke@fastmail.com> (Marius Bakke's message of "Fri, 9 Mar 2018 19:11:04 +0100") Message-ID: <87efkqtfly.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 30761@debbugs.gnu.org Marius Bakke skribis: > * guix/build-system/meson.scm (lower): Remove DEFAULT-PATCHELF from inputs > on armhf. > (meson-build): Ignore the 'fix-runpath' phase when building for arm syste= ms. [...] > + ;; XXX PatchELF fails to build on armhf, so we = skip > + ;; the 'fix-runpath' phase there for now. The > + ;; consequence is that some packages may have s= uperfluous > + ;; RUNPATH entries and thus runtime dependencie= s. Perhaps add a note that we use it to shrink the RUNPATH as described at . Otherwise LGTM, thanks! Ludo=E2=80=99.