From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 01/01: gnu: fftw: Build SIMD codelets.
Date: Thu, 03 May 2018 19:25:30 -0400
Message-ID: <87efisjp91.fsf@netris.org>
References: <20180417212549.1283.62731@vcs0.savannah.gnu.org>
	<20180417212551.BB270208E4@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1fENcS-0002yd-Ua
	for guix-devel@gnu.org; Thu, 03 May 2018 19:26:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1fENcP-0004LQ-0X
	for guix-devel@gnu.org; Thu, 03 May 2018 19:26:36 -0400
Received: from world.peace.net ([64.112.178.59]:33142)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mhw@netris.org>) id 1fENcO-0004Fn-Rg
	for guix-devel@gnu.org; Thu, 03 May 2018 19:26:32 -0400
In-Reply-To: <20180417212551.BB270208E4@vcs0.savannah.gnu.org> (Eric Bavier's
	message of "Tue, 17 Apr 2018 17:25:51 -0400 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <bavier@cray.com>
Cc: guix-devel@gnu.org

Hi Eric,

ericbavier@centurylink.net (Eric Bavier) writes:

> bavier pushed a commit to branch core-updates
> in repository guix.
>
> commit 65bb22796f854cbc3eae053a80b1d64365dad376
> Author: Eric Bavier <bavier@cray.com>
> Date:   Fri Apr 6 10:53:06 2018 -0500
>
>     gnu: fftw: Build SIMD codelets.
>     
>     * gnu/packages/algebra.scm (fftw)[arguments]: Remove 'no-native phase; use
>     configure cache value instead.  Add configure flags for SIMD codelets.
>     (fftwf)[arguments]: Add neon configuration flag for 32-bit arm.
>     (fftw-avx): Remove variable.

[...]

> @@ -560,7 +569,10 @@ cosine/ sine transforms or DCT/DST).")
>      (arguments
>       (substitute-keyword-arguments (package-arguments fftw)
>         ((#:configure-flags cf)
> -        `(cons "--enable-float" ,cf))))
> +        (if (string-prefix? "arm" (or (%current-target-system)
> +                                      (%current-system)))
> +            `(cons "--enable-neon" ,cf)
> +            cf))))

Did you intend to remove the "--enable-float" configure flag in fftwf?
You didn't mention this change in the commit log.

The description of fftwf appends "Single-precision version" to the
description from fftw, but since your commit above, the fftw and fftwf
packages are identical except on armhf, as far as I can tell.  On armhf,
the build now fails with "configure: error: NEON requires single
precision".

  https://hydra.gnu.org/build/2674813/nixlog/1/tail-reload

Can you take a look?

      Mark