From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUD3d-0003EU-Um for guix-patches@gnu.org; Sat, 16 Jun 2018 11:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUD3a-0005uu-Qo for guix-patches@gnu.org; Sat, 16 Jun 2018 11:24:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUD3a-0005uf-Il for guix-patches@gnu.org; Sat, 16 Jun 2018 11:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUD3a-0004gu-Cn for guix-patches@gnu.org; Sat, 16 Jun 2018 11:24:02 -0400 Subject: [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5. Resent-Message-ID: From: Kei Kebreau References: <20180606094730.15892-1-ambrevar@gmail.com> <87o9gd2zcy.fsf@posteo.net> <87lgbh2yv5.fsf@posteo.net> <877emyhlo6.fsf@gmail.com> Date: Sat, 16 Jun 2018 11:23:33 -0400 In-Reply-To: <877emyhlo6.fsf@gmail.com> (Pierre Neidhardt's message of "Sat, 16 Jun 2018 16:04:57 +0200") Message-ID: <87efh63gcq.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 31733@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Neidhardt writes: >>> Any particular reason you decided to use '(zero? (system* ...))' rather >>> than '(invoke ...)' for this phase? I tried it with 'invoke' and it >>> worked fine. > > I did not know about `invoke' :) > I just found its definition in guix/build/utils.scm. > Well now you know! :) >> Also, do note that the snippet needs to be updated, as bundled libraries >> (now including googletest) have moved to the "vendor" subdirectory. Once >> you remove the "vendor" subdirectory, you may have to add 'googletest' >> from '(gnu packages check)' to the native-inputs. > > So the vender directory has 3 dependencies: > > - tinyxml which is already used externally, so it's safe to remove the > embedded version. > > - easyloggingpp which is not packaged in Guix I believe. We need to > package it first before we can remove it. > Observation agrees with both of these. > - googletest: this one does not have an option in CMakeList.txt to be > used externally. So either we report upstream or we patch the > CMakeList.txt. > I see that while CMakeLists.txt doesn't have an external option to control this, it *does* look for googletest in the vendor directory. Perhaps we can add our own googletest as a native input and remove the bundled googletest and CMakeLists.txt's references to it in a snippet? > All things considered, why not sticking to the vendored libraries? > We try to unbundle third-party software in our packages in order to ease the burden of security maintenance and avoid duplication of work in general. There are probably other reasons that I can't remember right now, too. > What do you think? This sounds actionable to me! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlslK3UACgkQ5qXuPBlG eg0RuQ/8D5PP86x4FBLZp+/oUn1Pkz8MOtW059JKR1HyXDOa98jMDfU0oM9MkS8O GBujWGWOuwO0u5vhIjlfpWMNwA9MZRBlQyxOSj/9VJ8LWZ2aKBWs/iX9CqJIqDjp zZsRs9E4ANKWNbAEWrBjDZ3iu34Jx3HazU9TSNHPRT9PoEwAejTlfdZAQM2htMZP V2bHwSHeKAiO1ESSANN2jinVLgsKBqMoL7l2KjGyMKm59GdeVIdx3Lc3mHpErnZ1 J/LHtExqSoYtQBkSdmUOKOofy00TvUVuOJU5a7OxD/9tuoCn2lugpeBDfjzuyOVr iFQegRlrXlJR9SZIhW2Lz9JrvsxHQoOg1FjERNf3/8GxUmYAswpXi30rO9ECjygj mJSja0nfBvybHEzc7vjCGUBzCf8gwHlFIXJYHEU0wE4fPshBkdIN37F7U3IfbpLQ MzbUZhObLTNzVtexl11gywZ5ib8uXWMoHZqJWAhWnQbUVwsLmDWPbvO4zqwa0RsO MAe+r+CoQsPV5yl6bpE6DzXhzPzeUGu2OPq3c6oYKnAQn0wJB4E94IF1GEa5cdal QCU6yqG/bt9NCAZY3bzGZ2U7pANl1qJUdo14anu4365L3bTCVyrKfCfdCuid430Z 3VGmzgMWhoQIJJORR9I6xWR2nv3LMajE9SsuE+rsT3Hejql+044= =gCBb -----END PGP SIGNATURE----- --=-=-=--