From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: bug#31974: If a phase returns #f, a warning is issued, but the build continues Date: Mon, 25 Jun 2018 23:13:03 -0400 Message-ID: <87efgu8clc.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXeRe-0007Es-Pc for bug-guix@gnu.org; Mon, 25 Jun 2018 23:15:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXeRa-0007d3-8w for bug-guix@gnu.org; Mon, 25 Jun 2018 23:15:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXeRa-0007cz-5R for bug-guix@gnu.org; Mon, 25 Jun 2018 23:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXeRa-0005Kf-0t for bug-guix@gnu.org; Mon, 25 Jun 2018 23:15:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXeQy-000730-6Y for bug-guix@gnu.org; Mon, 25 Jun 2018 23:14:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXeQu-0007Oh-SF for bug-guix@gnu.org; Mon, 25 Jun 2018 23:14:24 -0400 Received: from world.peace.net ([64.112.178.59]:42294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fXeQu-0007OR-O7 for bug-guix@gnu.org; Mon, 25 Jun 2018 23:14:20 -0400 List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 31974@debbugs.gnu.org I just noticed that I made a mistake in commit d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in (guix build gnu-build-system) to issue a warning if a phase returns a value other than #t. The result is that if a phase returns a value other than #t, a warning is issued, but the build nonetheless continues to the next phase, and the build could ultimately "succeed" even some phases returned #f. In other words, the return values of phases are effectively ignored, except for the warning, so the only way to cause a build with phases to fail is to raise an exception. We can't fix this problem without a full rebuild. Sorry about that :-( The only good news here is that I've already fixed all of the core packages to return #t from all phases and to report errors using exceptions. Ditto for all of the packages that I use on my GNOME desktop. The remaining packages that might return #f from a phase could be fixed in 'master'. Mark