From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcVQb-0000Za-8j
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:38:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcVQY-0003ZP-5H
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:38:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43913)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fcVQY-0003ZJ-1F
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:38:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcVQX-0002yI-R6
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:38:01 -0400
Subject: [bug#32053] [PATCH 2/2] gnu: Add quaternion.
Resent-Message-ID: <handler.32053.B32053.153113987811413@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180704174239.30870-1-arunisaac@systemreboot.net>
	<20180704174637.31129-1-arunisaac@systemreboot.net>
Date: Mon, 09 Jul 2018 14:37:46 +0200
In-Reply-To: <20180704174637.31129-1-arunisaac@systemreboot.net> (Arun Isaac's
	message of "Wed, 4 Jul 2018 23:16:37 +0530")
Message-ID: <87efgch9et.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 32053@debbugs.gnu.org

Hello,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/messaging.scm (quaternion): New variable.

[...]

> +    (inputs
> +     `(("libqmatrixclient-source" ,(package-source libqmatrixclient))
> +       ("qt" ,qt)))
> +    (arguments
> +     `(#:tests? #f ; No tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'unpack-libqmatrixclient
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (invoke "tar" "-C" "lib" "-xvf"
> +                     (assoc-ref inputs "libqmatrixclient-source")
> +                     "--strip-components=3D1"))))))

That doesn=E2=80=99t sound great.  :-)

Could we arrange to have it use an externally-built libqtmatrixclient.so?
Perhaps that=E2=80=99ll involve modifying the CMake/Qt/whatever build files?

> +    (home-page "https://matrix.org/docs/projects/client/quaternion.html")
> +    (synopsis "Qt5 desktop client for the Matrix protocol")

What about: =E2=80=9CGraphical client for the Matrix instant messaging prot=
ocol=E2=80=9D?

> +    (description "Quaternion is a Qt5 desktop client for the Matrix prot=
ocol.

s/protocol/instant messaging protocol/

It=E2=80=99s all about giving enough context so that people know what kind =
of
matrix we=E2=80=99re talking about.  ;-)

Thank you,
Ludo=E2=80=99.