From: Ricardo Wurmus <rekado@elephly.net>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 32809@debbugs.gnu.org
Subject: [bug#32809] [PATCH 1/1] import: hackage: Do not repeat inputs in native-inputs.
Date: Sat, 27 Oct 2018 20:16:12 +0200 [thread overview]
Message-ID: <87efcb45n7.fsf@elephly.net> (raw)
In-Reply-To: <cu7va6um7br.fsf@systemreboot.net>
Hi Arun,
>>> * guix/import/hackage.scm (hackage-module->sexp): Do not repeat inputs again
>>> in native-inputs. native-inputs should only contain packages that are not
>>> already listed in inputs.
>>
>> Aha? When cross-compiling, will guix provide all the tools natively that are
>> listed in inputs? (rather than just the ones in native-inputs)
>
> That's a good question. I did not think of it, and I don't know the
> answer. Whenever I have packaged any package (Haskell packages,
> included) for Guix, I have taken care to not repeat the inputs in the
> native-inputs. Now that you mention this, I don't know if that was the
> right thing to do. WDYT?
Currently, the haskell-build-system says this about cross-building
packages:
XXX: no cross-compilation
Until we have patches to add proper cross-compilation support to the
Haskell build system, I’d prefer to let the importer only keep packages
that are not already listed in the inputs.
This is probably the right thing to do. It may even be correct to have
all Haskell *libraries* among the regular inputs and only test *tools*
be build-host native.
The Cabal format does not differ between these cases. It only supports
specifications of different build targets with arbitrary names and
usually with full lists of dependencies, even if the dependencies might
be duplicates of those used for other build targets.
In short: the patch looks good to me.
Thanks!
--
Ricardo
next prev parent reply other threads:[~2018-10-27 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 17:18 [bug#32809] [PATCH 0/1] import: hackage: Do not repeat inputs in native-inputs Arun Isaac
2018-09-22 17:27 ` [bug#32809] [PATCH 1/1] " Arun Isaac
2018-09-23 15:10 ` Danny Milosavljevic
2018-09-25 6:15 ` Arun Isaac
2018-10-27 18:16 ` Ricardo Wurmus [this message]
2018-10-28 9:16 ` bug#32809: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efcb45n7.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=32809@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.