From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in master? Date: Fri, 23 Nov 2018 16:31:26 +0100 Message-ID: <87efbb4xpt.fsf@gnu.org> References: <87lg6sejwa.fsf@gmail.com> <87wopd88hq.fsf@gmail.com> <877ehcsocq.fsf@gnu.org> <87bm6oxsyf.fsf@gmail.com> <87a7m7yhu5.fsf@gmail.com> <878t1rygfu.fsf@gmail.com> <877ehbydmz.fsf@gmail.com> <87sgzykmyx.fsf@gnu.org> <877eh9245u.fsf@gmail.com> <87efbgx0p0.fsf@gnu.org> <87sgzw5ylb.fsf@gmail.com> <87zhu1cw4p.fsf_-_@gnu.org> <875zwp17od.fsf@gmail.com> <87lg5j6h00.fsf@gnu.org> <87pnuv26jv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQDQh-0005NP-U0 for guix-devel@gnu.org; Fri, 23 Nov 2018 10:31:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQDQh-0006q7-2P for guix-devel@gnu.org; Fri, 23 Nov 2018 10:31:39 -0500 In-Reply-To: <87pnuv26jv.fsf@gmail.com> (Mathieu Othacehe's message of "Fri, 23 Nov 2018 23:48:52 +0900") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mathieu Othacehe Cc: Guix-devel Mathieu Othacehe skribis: >> Now, why does the default value of LANG matter anyway? I mean, the >> installer starts out with a default language, presumably English, right? >> So you can simply add, say, (setenv "LC_ALL" "en_US.utf8") when starting >> the installer, can=E2=80=99t you? > > Yup its a way, but in the higly improbable case we want to distribute > install images with the 'locale' field of 'installation-os' set to > something else than en_US.utf8, then LANG matters. I found a hack > consisting in loading everything in /etc/environment just before > starting the installer but I'm not very proud of it! Heheh. Another option would be to pass the locale name to the installer right from (gnu system install). That way, if people want to build an image with a different default locale, they can do it. Fundamentally though, it=E2=80=99s the installer=E2=80=99s job to offer a c= hoice of languages early on, which it does pretty well already! > I just pushed to wip-newt-installer some commits. Most of what you > described in points 1, 2 and 3 should be ok. The part, I'm not sure > about and I would like you to have a look is the (guix self) part. I'm > not sure I understand the point of having a *installer-modules* > scheme-node if we don't want to build and distribute the installer via > (guix self). > > So what I did is removing (gnu system install) from *system-modules* so > that, all references to the installer is absent from (guix self), but > maybe it's not the right thing to do. I think we want to distribute (gnu installer =E2=80=A6) modules, just not b= uild them. The thing is, they should be =E2=80=9Cbuild-side only=E2=80=9D modul= es, and thus we don=E2=80=99t need to compile them; it=E2=80=99s like (guix man-db), for= instance. So I think gnu/installer/*.scm could go in the *system-modules* node as #:extra-files. Does that make sense? Thanks, Ludo=E2=80=99.