From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: 16/16: doc: Discourage the use of texlive as input Date: Sat, 15 Dec 2018 00:06:01 +0100 Message-ID: <87efaj1zfq.fsf@gnu.org> References: <20181214223246.22997.58804@vcs0.savannah.gnu.org> <20181214223250.89D882118D@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXwX3-0005aZ-Se for guix-devel@gnu.org; Fri, 14 Dec 2018 18:06:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXwX0-0002gX-8c for guix-devel@gnu.org; Fri, 14 Dec 2018 18:06:08 -0500 In-Reply-To: <20181214223250.89D882118D@vcs0.savannah.gnu.org> (guix-commits's message of "Fri, 14 Dec 2018 17:32:50 -0500 (EST)") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org, Pierre Neidhardt Hi Pierre! guix-commits@gnu.org skribis: > commit dc56dc025df0b7ea6915ad1061f8d189d641fe35 > Author: Pierre Neidhardt > Date: Fri Dec 14 23:06:06 2018 +0100 > > doc: Discourage the use of texlive as input >=20=20=20=20=20 > * doc/contributing.texi (Submitting Patches): Discourage the use of t= exlive as > input. > --- > doc/contributing.texi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/doc/contributing.texi b/doc/contributing.texi > index c55eb63..9f705d2 100644 > --- a/doc/contributing.texi > +++ b/doc/contributing.texi > @@ -477,6 +477,16 @@ often better to clone the repository. Don't use the= @command{name} field in > the URL: it is not very useful and if the name changes, the URL will pro= bably > be wrong. >=20=20 > +@item > +Try to minimize the weight of the inputs to make the transitive closure = as > +small as possible (@pxref{Invoking guix size}). Use @command{native-inp= uts} > +and @command{inputs} appropriately. It's sometimes sufficient to use the > +@command{-minimal} version of a package as input, e.g. @command{bash-min= imal} > +instead of @command{bash}. In particular, avoid adding @command{texlive= } as a > +dependency: because of its extreme size, it's both heavy on the build fa= rms > +and on the users who would like to build or hack the package from source= . Use > +@command{texlive-tiny} or @command{texlive-union} instead. The text looks fine but I find it a bit long and more importantly it partly duplicates an item that=E2=80=99s just above :-), which mentions =E2= =80=98guix size=E2=80=99 but not =E2=80=98texlive=E2=80=99. So I=E2=80=99d rather not add this item because it shows that this section = is already too long to be read. Perhaps a =E2=80=98lint=E2=80=99 checker warning about =E2=80=98texlive=E2= =80=99 as an input would be more appropriate? WDYT? In general I think it=E2=80=99s a good idea to discuss changes to the guide= lines beforehand, as per =E2=80=98HACKING=E2=80=99. Anyway thanks for all the latest TeX Live improvements. It=E2=80=99s great= you managed to replace all these =E2=80=98texlive=E2=80=99 dependencies with =E2=80=98texlive-union=E2=80=99! Ludo=E2=80=99.