From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm4aT-0006hB-Ly for guix-patches@gnu.org; Tue, 22 Jan 2019 17:32:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm4aR-0003cV-ME for guix-patches@gnu.org; Tue, 22 Jan 2019 17:32:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm4aQ-0003bW-I8 for guix-patches@gnu.org; Tue, 22 Jan 2019 17:32:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gm4aQ-0006sA-BJ for guix-patches@gnu.org; Tue, 22 Jan 2019 17:32:02 -0500 Subject: [bug#33185] [PATCH 6/7] gnu: Add patchwork. Resent-Message-ID: References: <20181104104455.3527-1-mail@cbaines.net> <20181104104455.3527-6-mail@cbaines.net> <87h8gdxbu0.fsf@gnu.org> From: Christopher Baines In-reply-to: <87h8gdxbu0.fsf@gnu.org> Date: Tue, 22 Jan 2019 22:31:24 +0000 Message-ID: <87ef94iatf.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33185@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> --- >> gnu/packages/patchutils.scm | 103 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 103 insertions(+) > > [...] > >> + (add-after 'install 'install-patchwork-admin >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out"))) >> + (mkdir-p (string-append out "/bin")) >> + (call-with-output-file (string-append out "/bin/patchwor= k-admin") >> + (lambda (port) >> + (display "#!/usr/bin/env python3 >> +import os, sys >> + >> +if __name__ =3D=3D \"__main__\": >> + os.environ.setdefault( >> + \"DJANGO_SETTINGS_MODULE\", >> + \"guix.patchwork.settings\" >> + ) >> + >> + from django.core.management import execute_from_command_line >> + >> + execute_from_command_line(sys.argv)" port))) >> + (chmod (string-append out "/bin/patchwork-admin") #o555)) >> + #t))))) > > IMO these phases would be less intimidating with a few comments > explaining what=E2=80=99s going on. :-) > >> + (synopsis "") >> + (description "") >> + (home-page "") >> + (license ""))) > > As swedebugia noted, you=E2=80=99re missing a few things here and in the = commit > log. :-) > > With these things fixed it should be good! Thanks for taking a look. I've finally got around to taking another look at these patches, and sent updated patches for the package, service and system test. I think it's a lot further forward, but there are still a few bits to sort out. I'll send some comments in reply to the patches. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxHmbxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xew2BAAqagVbKEY7gKlXY6Sn/zR2XSi/wbkjWcNnNEXoY61IPauqWjEBDQF/sUS m/zgcpvBq3pYuTdchcuZwgymfgtYLmelxE9SolfSbaA76QNEdFvUz6UbjX3Hj1rS oNsLzKxyQQOSz15AOnR9GDlhJhBM1/ndULFH7K/meIuwcvJK+Gt4NZrd+S/aEyoA Ua8jH1XRW59hagQ9jprr/Xu6Nn0DWMyHw4OH3my8GvhpmMHLAF3PE3KrVe/is3Hs G2Eu4Lhh1+nhLnerTuOTwygT6FR0L90wILx6bEjvfOQCYruH0FAof3HU91vXwHVk Cq1NsYJbn10Yg3HEWZtS7oC0CWLcO1ixBjyVcq0XTXJEpiHcIZB1nen0A7oB29YW GaLELIdU6Y3GRSzkVXhTLw3YTX0rxawPjwQuj6lNX5+DiVzzLgNe7BtbsETXIDcp caNTtj6SNNqh9Fcy9pykKyYH+GQWY0jZwRYZAgQ07Y0woZpPrdVe9cSM+gPU6XKP 2JAGcnrCbY9Qe8HelegpLyWkSG0t3Urlf6fDfBt693WsrnvD0O7Hd2zuH1oQc94s +dZyqxsPy99axLF66jv7jakgD1K+xNYPN+quodlFnNMaP7t9k/apA0RIt75dapT0 8p9I3VVXiHUfYO3QB29chZV/5jr+J6KCS8bdhPxW4JU+SGGnOBE= =eF/9 -----END PGP SIGNATURE----- --=-=-=--