From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnOPL-0006xP-5T for guix-patches@gnu.org; Sat, 26 Jan 2019 08:54:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gnOPK-00060f-7f for guix-patches@gnu.org; Sat, 26 Jan 2019 08:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gnOPK-00060W-3x for guix-patches@gnu.org; Sat, 26 Jan 2019 08:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gnOPJ-0006ye-VE for guix-patches@gnu.org; Sat, 26 Jan 2019 08:54:02 -0500 Subject: [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8736pzpnhg.fsf@elephly.net> <20190111094208.28327-1-rekado@elephly.net> <87bm49itkj.fsf@gnu.org> <87k1isvhbe.fsf@elephly.net> <87y378moax.fsf@gnu.org> <87fttgv25x.fsf@elephly.net> Date: Sat, 26 Jan 2019 14:53:15 +0100 In-Reply-To: <87fttgv25x.fsf@elephly.net> (Ricardo Wurmus's message of "Fri, 25 Jan 2019 22:48:58 +0100") Message-ID: <87ef8zle44.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34040@debbugs.gnu.org Halo! Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >>>> Alternately, we could change =E2=80=98input-changes=E2=80=99 to =E2=80= =98inputs=E2=80=99, which would be >>>> absolute, not relative, and thus =E2=80=98package-update=E2=80=99 woul= d take care of >>>> calling =E2=80=98changed-inputs=E2=80=99 etc. >>> >>> That would also work, but I think I prefer an updater to report changes >>> rather than a new list of inputs. >> >> OTOH if we return a complete list of inputs, then we don=E2=80=99t have = to worry >> about the cost of =E2=80=98changed-inputs=E2=80=99 since that would only= be called on >> demand; also there=E2=80=99d be a single call site for =E2=80=98changed-= inputs=E2=80=99. > > The potentially expensive part is to get the inputs, though. Getting a > list of new inputs means that the importer needs to be run. For CRAN > packages this requires downloading the tarball and unpacking parts of > it. Oh right. Then perhaps could have a separate =E2=80=98inputs=E2=80=99 field, which would be either #f or that procedure = to fetch the list of inputs for the given package. Does that make sense? (I=E2=80=99m thinking out loud=E2=80=A6) Ludo=E2=80=99.