From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsCcB-0003BF-Ir for guix-patches@gnu.org; Fri, 08 Feb 2019 15:19:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsCc7-0001ZH-VC for guix-patches@gnu.org; Fri, 08 Feb 2019 15:19:11 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsCc7-00018q-Ox for guix-patches@gnu.org; Fri, 08 Feb 2019 15:19:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gsBAz-0005Sy-PQ for guix-patches@gnu.org; Fri, 08 Feb 2019 13:47:02 -0500 Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba. Resent-Message-ID: References: <87zhrmgy0x.fsf@cbaines.net> <20190127114956.26570-1-mail@cbaines.net> <20190127114956.26570-11-mail@cbaines.net> <87lg32nw2f.fsf@elephly.net> <754595d3-c267-485d-d0c0-a3782b88c89f@riseup.net> <1dedc991-9515-3897-cfa1-ae4f55158851@riseup.net> From: Christopher Baines In-reply-to: <1dedc991-9515-3897-cfa1-ae4f55158851@riseup.net> Date: Fri, 08 Feb 2019 18:46:02 +0000 Message-ID: <87ef8i5dat.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: swedebugia Cc: 34217@debbugs.gnu.org --=-=-= Content-Type: text/plain swedebugia writes: > On 2019-01-30 17:22, swedebugia wrote: >> On 2019-01-30 17:11, swedebugia wrote: >>> On 2019-01-30 13:56, Ricardo Wurmus wrote: >>>> >>>> Hi swedebugia, >>>> >>>>> On 2019-01-27 12:49, Christopher Baines wrote: >>>>>> These packages are mutually dependant, so I've put them in one commit. >>>>>> >>>>>> * gnu/packages/ruby.scm (ruby-aruba, ruby-cucumber): New variables. > snip > >>> I don't know ruby at all so I might not be the best qualified to >>> investigate this. :/ > > I decided to try out latest master, worked a little on it and now it > builds without failure! :D > > I'm unsure what revision number we usually start on, please correct if > necessary. > > (define-public ruby-aruba > ;; Take commit from latest master to avoid test failures > > > > (let ((commit "688ad050f48990bfac127eaf529a828a0139d85f") > (revision "1")) ... > Could you update the patch Christopher? Thanks for trying this out. Today I tried updating to 0.14.8, and working around the test failures. I've added the following phase, which works around the test failures. (add-after 'unpack 'patch (lambda _ (substitute* "spec/aruba/api_spec.rb" ;; This resolves some errors in the specs ;; ;; undefined method `parse' for Time:Class (("require 'spec_helper'") "require 'spec_helper'\nrequire 'time'")) ;; Avoid shebang issues in this spec file (substitute* "spec/aruba/matchers/command_spec.rb" (("/usr/bin/env bash") (which "bash"))) #t)) The first change, adding require 'time' is present on the upstream master branch [1], which explains why this helped. 1: https://github.com/cucumber/aruba/commit/7d11cad400bbbfd1ec039e39062f7f2576d970f6#diff-b014353d9f47f067ea8e078d34a1826b As for the second set of test failures, the ones relating to "@cmd", I think that's down to the spec's using "/usr/bin/env bash". I'm unsure why using the master branch would have fixed this. Even though sticking with 0.14.8 requires patching the tests, I'm inclined to stick with patching this release, rather than using the master branch as the source, as I think using upstream releases is preferable. Anyway, thanks for your help in looking in to this :) Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxdzmpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XczIhAAs2Z9srF1/lAfLASqJaCEx5+TALY30rFsb4ggV4cZLS2U4I62TVeXjlJU kZnURT3uNV2Ku195UOMNlQAujLz0gPi22fuc1+E24HHBKAgUZfkP9QZDn04ihihh MWU5evGgeW6eKYChA1dXWie6lunvDHYbgCVw//eo2SLiBpRf9R/T/I9QPzxiWEV7 KKDMaMZBMwnnx5FIRO6kEVy/6pPjxzzbNMzRR5NYBDhz3qvEwsq/9PMqRw+s4bm4 7i4/nTFqy4jCFzqqKwOgQAxD6PbbjjjOdXSw5naYg8xT1QcYAddoDdbsA9cyqLDt ZYgwNH4MGNLyI67TSjdxTMh6/tj9j1ltfosEWb9l/NDuTwxEUgOsBO8s/sCk9n6T hHpmM/coF+tFe3+FdsL/fxUlr0r7iqQaiYVTz6GA9Qd4NOMhrk3/lBsmo1KX/g7s DatJg6ITByHLWZThP6g8MGEXWasyFG3ede8asw4w2qLdP4YxTzU+yY25LI6Ap9/w kDYO9sq+O9lJ+7R5UymJmnZcyWHyN99a7kGmnRLtqO90i8i/fFFu1t1G1yEWh8b7 hcwXH/VpXrriTrUPS2U8n70zsLehci0rTuiTrqVHpkcgSt6QeTc6mDjeUqa6AfZf 0VNzO7iSG0+jG/jJjAaYtficDei31sGBqUf+2skdTu3ndV0cdIY= =dTl/ -----END PGP SIGNATURE----- --=-=-=--