From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 35880-done@debbugs.gnu.org
Subject: [bug#35880] [PATCH 1/7] lzlib: Add 'make-lzip-input-port/compressed'.
Date: Sat, 01 Jun 2019 11:41:59 +0200 [thread overview]
Message-ID: <87ef4dk5g8.fsf@gnu.org> (raw)
In-Reply-To: <87ef4dzvuy.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Sat, 01 Jun 2019 08:02:29 +0200")
Hi!
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> I think the ‘lzread!’ loop should look like this (the tests still pass
>> with this):
>>
>> --8<---------------cut here---------------start------------->8---
>> (let loop ((read 0)
>> (start start))
>> (cond ((< read count)
>> (match (lz-decompress-read decoder bv start (- count read))
>> (0 (cond ((lz-decompress-finished? decoder)
>> read)
>> ((eof-object? (feed-decoder! decoder))
>> (lz-decompress-finish decoder)
>> (loop read start))
>> (else ;read again
>> (loop read start))))
>> (n (loop (+ read n) (+ start n)))))
>> (else
>> read)))
>> --8<---------------cut here---------------end--------------->8---
>
> Looks good to me!
OK, committed!
>>> (match (lz-decompress-read decoder bv start (- count read))
>>> (0 (if (eof-object? (feed-decoder! decoder))
>>> read
>>> (loop read start)))
>>>
>>> I'm not sure I understand the above: if we read nothing, then we try
>>> again?
>>
>> No: if we read *something*, we try again; if we read nothing, we return.
>
> If we read nothing _and_ it is not an EOF (it can be an empty vector),
> then we loop indefinitely, no?
‘feed-decoder!’ cannot return an empty bytevector because
‘lz-decompress-write-size’ necessarily returns a strictly positive
integer at this point.
(Imperative programming is hard! :-))
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-06-01 9:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 13:31 [bug#35880] [PATCH 0/7] Lzip support for 'guix publish' and 'guix substitute' Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 1/7] lzlib: Add 'make-lzip-input-port/compressed' Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 2/7] utils: Test 'compressed-port' and 'decompressed-port' for both gzip and xz Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 3/7] utils: Support compression and decompression with lzip Ludovic Courtès
2019-05-25 17:27 ` Pierre Neidhardt
2019-05-26 19:52 ` Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 4/7] publish: Add support for lzip Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 5/7] self: Add dependency on lzlib Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 6/7] gnu: guix: " Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 7/7] lzlib: 'lzread!' never returns more than it was asked for Ludovic Courtès
2019-05-25 17:31 ` Pierre Neidhardt
2019-05-26 19:54 ` Ludovic Courtès
2019-05-26 20:57 ` Pierre Neidhardt
2019-05-26 21:28 ` Ludovic Courtès
2019-05-27 7:00 ` Pierre Neidhardt
2019-05-27 10:00 ` Ludovic Courtès
2019-05-25 17:24 ` [bug#35880] [PATCH 1/7] lzlib: Add 'make-lzip-input-port/compressed' Pierre Neidhardt
2019-05-26 19:51 ` Ludovic Courtès
2019-05-27 15:45 ` Ludovic Courtès
2019-05-27 16:24 ` Pierre Neidhardt
2019-05-27 20:53 ` bug#35880: " Ludovic Courtès
2019-05-27 21:12 ` [bug#35880] " Pierre Neidhardt
2019-05-28 7:52 ` Ludovic Courtès
2019-05-28 8:46 ` Pierre Neidhardt
2019-05-28 13:47 ` Ludovic Courtès
2019-05-29 14:57 ` Pierre Neidhardt
2019-05-31 20:54 ` Ludovic Courtès
2019-06-01 6:02 ` Pierre Neidhardt
2019-06-01 9:41 ` Ludovic Courtès [this message]
2019-06-01 9:58 ` Pierre Neidhardt
2019-06-01 12:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef4dk5g8.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35880-done@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.