From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYW88-00045q-8t for guix-patches@gnu.org; Wed, 05 Jun 2019 09:39:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYW87-0001Vr-0u for guix-patches@gnu.org; Wed, 05 Jun 2019 09:39:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33298) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYW85-0001To-TR for guix-patches@gnu.org; Wed, 05 Jun 2019 09:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hYW85-0004uo-PD for guix-patches@gnu.org; Wed, 05 Jun 2019 09:39:01 -0400 Subject: [bug#36082] [PATCH] add gnurobots Resent-Message-ID: References: <20190603161431.03842caa@gmail.com> From: Ricardo Wurmus In-reply-to: <20190603161431.03842caa@gmail.com> Date: Wed, 05 Jun 2019 15:38:06 +0200 Message-ID: <87ef48cfup.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jesse Gibbons Cc: 36082@debbugs.gnu.org Hi Jesse, > From 77168e843404ba8cddbace220a04d2d30d419a2f Mon Sep 17 00:00:00 2001 > From: Jesse Gibbons > Date: Mon, 3 Jun 2019 16:10:43 -0600 > Subject: [PATCH] add gnurobots Thank you for your patch. It looks like the patch doesn=E2=80=99t apply to= the git repository. Maybe it got mangled by your email client? I=E2=80=99ll continue with some comments about the patch. > + > + Please remove the extra line break. > +(define-public gnurobots > + (package > + (name "gnurobots") > + (version "1.2.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnu/gnurobots/gnurobots-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "07gi3lsmbzzsjambgixj6xy79lh22km84z7bnzgwzxdy806lyvwb")))) The indentation looks off. I can fix this for you, of course, or you could use the automatic indenter script; see the Contributing section in the manual for more information. > + (build-system gnu-build-system) > + (inputs > + `(("glib" ,glib) > + ("gtk+" ,gtk+-2) > + ("vte" ,vte/gtk+-2) > + ("readline" ,readline) > + ("guile" ,guile-1.8) > + ("pkg-config" ,pkg-config))) > + (arguments '( Please don=E2=80=99t leave parentheses dangling on their own like that. Th= ey need company. > + ;-Werror=3Ddeprecated-declarations kills the build. Fix > it! Please use =E2=80=9C;;=E2=80=9D for comments on their own line. Single sem= icolon is used for =E2=80=9Cmargin comments=E2=80=9D, i.e. a comment at the end of a = line. > + #:make-flags > '("CFLAGS=3D-Wno-error=3Ddeprecated-declarations") > + #:phases > + ;readline headers were moved to readline/readline.h. > Fix before we compile. Same here. Please also use full sentences when necessary. I=E2=80=99d say= no comment is necessary here. > + (modify-phases %standard-phases > + (add-before 'build > 'patch-shell-references Please change the name of this build phase. =E2=80=9Cpatch-shell-reference= s=E2=80=9D does not describe what this phase does. > + (lambda _ > + (begin You don=E2=80=99t need =E2=80=9Cbegin=E2=80=9D here. > + > (substitute* (find-files "src" "\\.c$") > + > (("") "")) > + > (substitute* (find-files "src" "\\.c$") > + > (("") "")))))))) You could merge these two substitutions; after all they operate on the same set of files. However, I think that a better approach might be to add the =E2=80=9Creadline=E2=80=9D sub-directory to C_INCLUDE_PATH. So ins= tead of patching files you=E2=80=99d just set one environment variable. > + (synopsis > + "Program a little robot and watch him explore a world") =E2=80=9Chim=E2=80=9D =E2=80=93> =E2=80=9Cit=E2=80=9D > + (description > + "GNU Robots is a game in which you program a robot to explore a > world +full of enemies that can hurt it, obstacles and food to be eaten. > +The goal of the game is to stay alive and collect prizes. The robot > +program conveniently may be written in a plain text file in the > +Scheme programming language.") > + (home-page > + "http://www.gnu.org/software/gnurobots/readme.html") Plesae use HTTPS and remove the =E2=80=9C/readme.html=E2=80=9D part. > + (license gpl3+))) This should be =E2=80=9C(license license:gpl3+)=E2=80=9D because all values= from the (guix licenses) module are imported with a =E2=80=9Clicense:=E2=80=9D prefi= x. Would you like to send a new patch? If you aren=E2=80=99t comfortable with= =E2=80=9Cgit send-email=E2=80=9D please attach the generated patch file to your email (d= on=E2=80=99t copy/paste the contents). Thanks! -- Ricardo