From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:35389)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iQXhg-0004JQ-9f
 for guix-patches@gnu.org; Fri, 01 Nov 2019 10:15:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iQXhf-0001SA-AF
 for guix-patches@gnu.org; Fri, 01 Nov 2019 10:15:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47928)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iQXhf-0001Ru-6o
 for guix-patches@gnu.org; Fri, 01 Nov 2019 10:15:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iQXhe-00046r-SE
 for guix-patches@gnu.org; Fri, 01 Nov 2019 10:15:03 -0400
Subject: [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused
 package)
Resent-Message-ID: <handler.37908.B37908.157261765815703@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191024192056.5428-1-h.goebel@crazy-compilers.com>
 <20191025103449.GI15460@E5400> <20191025104300.GK15460@E5400>
 <87ftjgldd4.fsf@gnu.org>
 <3917a043-2800-a2e7-781c-48d23f0aed40@crazy-compilers.com>
 <87imo3euqw.fsf@gnu.org>
 <531d87da-8ad9-e6e9-cfce-9d447e9b5233@crazy-compilers.com>
Date: Fri, 01 Nov 2019 15:14:08 +0100
In-Reply-To: <531d87da-8ad9-e6e9-cfce-9d447e9b5233@crazy-compilers.com>
 (Hartmut Goebel's message of "Fri, 1 Nov 2019 13:18:58 +0100")
Message-ID: <87eeyrd6q7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 37908@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> From: Hartmut Goebel <h.goebel@crazy-compilers.com>
> Date: Thu, 24 Oct 2019 20:28:26 +0200
> Subject: [Patch v2 2/2] gnu: Deprecate monolithic qt5.
>
> This package was not used anywhere but as a based for qt-4.
>
> * gnu/packages/qt.scm (qt-4): Copy all relevant package definition
>   parts from 'qt'.
>   (qt): Define as a deprecated alias for 'qtbase`.

Please ensure that =E2=80=9Cguix build qt@4 -nd=E2=80=9D returns the same d=
erivation
before and after the change.

> +(define-deprecated qt qtbase qtbase)

Perhaps add a comment above saying that =E2=80=98qt=E2=80=99 used to refer =
to the
monolithic Qt 5.x package?

Otherwise LGTM!  Efraim, can you say if this is fine with you?
When Efraim agrees to the change, I guess you can go ahead.

Thank you,
Ludo=E2=80=99.