From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:34978)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iSJOx-00076M-Cs
 for guix-patches@gnu.org; Wed, 06 Nov 2019 06:23:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iSJOw-0007mj-8x
 for guix-patches@gnu.org; Wed, 06 Nov 2019 06:23:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:58934)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iSJOw-0007mF-5N
 for guix-patches@gnu.org; Wed, 06 Nov 2019 06:23:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iSJOv-00076t-Ui
 for guix-patches@gnu.org; Wed, 06 Nov 2019 06:23:02 -0500
Subject: [bug#38075] [PATCH] services: mpd: add pulseaudio support
Resent-Message-ID: <handler.38075.B38075.157303936027284@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191105224645.12269-1-robertsmith@posteo.net>
Date: Wed, 06 Nov 2019 12:22:29 +0100
In-Reply-To: <20191105224645.12269-1-robertsmith@posteo.net> (Robert Smith's
 message of "Tue, 5 Nov 2019 23:46:46 +0100")
Message-ID: <87eeyl8d1m.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Robert Smith <robertsmith@posteo.net>
Cc: 38075@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>, Leo Famulari <leo@famulari.name>

Hi,

(Cc=E2=80=99ing Leo and Tobias who have been taking care of the mpd package=
 and
service.)

Robert Smith <robertsmith@posteo.net> skribis:

> Set the XDG_RUNTIME_PATH environment variable in the mpd service so
> that it can detect pulseaudio when run under a user account.
> ---
>  gnu/services/audio.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
> index 471c5fd95f..424ccc7c8f 100644
> --- a/gnu/services/audio.scm
> +++ b/gnu/services/audio.scm
> @@ -140,6 +140,12 @@ audio_output {
>                     "--no-daemon"
>                     #$(mpd-config->file config))
>               #:pid-file #$(mpd-file-name config "pid")
> +             #:environment-variables
> +             '(#$(string-append
> +                   "XDG_RUNTIME_DIR=3D/run/user/"
> +                   (number->string
> +                     (passwd:uid=20
> +                       (getpwnam (mpd-configuration-user config))))))
>               #:log-file #$(mpd-file-name config "log")))

I suppose this is meant for the libpulse client library, right?  (I=E2=80=
=99m
surprised it=E2=80=99s not the default, but apparently that=E2=80=99s the w=
ay it is.)

Note that this also has an effect on mpd itself from what I can see in
the source: mpd will listen to $XDG_RUNTIME_DIR/mpd/socket instead of
(in addition to?) listening on TCP.

I don=E2=80=99t use mpd myself; could you ensure that the socket change is =
also
fine and doesn=E2=80=99t cause any troubles for mpd clients?

Thanks,
Ludo=E2=80=99.