From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: bug#40528: 'guix lint' does not check whether propagated-inputs
 should be native
Date: Thu, 09 Apr 2020 23:42:18 +0200
Message-ID: <87eeswjpz9.fsf@devup.no>
References: <87h7xsjqt2.fsf@devup.no> <20200409213131.GX1518@E5400>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:45193)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMewx-0001aN-HB
 for bug-guix@gnu.org; Thu, 09 Apr 2020 17:43:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMeww-0002rp-I3
 for bug-guix@gnu.org; Thu, 09 Apr 2020 17:43:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43031)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jMeww-0002re-CN
 for bug-guix@gnu.org; Thu, 09 Apr 2020 17:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMeww-0004ok-B2
 for bug-guix@gnu.org; Thu, 09 Apr 2020 17:43:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.40528.B40528.158646855018481@debbugs.gnu.org>
In-Reply-To: <20200409213131.GX1518@E5400>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 40528@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Efraim Flashner <efraim@flashner.co.il> writes:

> On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
>> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
>> a package, not propagated-inputs.
>
> The attached patch should add the propagated inputs to the list of
> inputs to check. Do we want to start telling it to ignore some of them?

Wow, that was incredibly fast!

> gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' should probably be a native input

I'm inclined to leave it.  I think many of these plugin packages should
not be propagating the package that they plug into anyway.

LGTM!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6PlrsACgkQoqBt8qM6
VPpHtgf/W0xedlDc5Wk7a1zlE5jreEhow+SjZdYw1rzXxzNR7QKoDtIgkCUA4Zpd
+CNEsnMncaCXQSi7tjqeAmHLWaxnAlkv+J5KOeOW0adWtgyOCabOK3xJWB9fRuhy
/hlvX4mWModGGky6G2CYbKiYGxEj6xG2Ol4Cs0TJ2cghWYdC8dyGljMxiTPAvoEL
zuWhTH+QVdjGYbliwEcTZO/zOb4uBbf4pL2eqHXj6djscqMyS4cH7xiZ4hfOPUgy
NFl0EJ5O0Xn2QSfInf3sD77GticAfzIpDC83VaF8i07A5qW9pNPaydHkQBC8AJoG
jdpCCPKqqD/g8pw1cJqY3wBegxQyMw==
=H5Jx
-----END PGP SIGNATURE-----
--=-=-=--