From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53628) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNJON-0006hb-It for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNJOM-0007zw-EM for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45492) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNJOM-0007zh-5q for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNJOM-0008Dj-4M for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:02 -0400 Subject: [bug#40556] [PATCH] gnu: dovecot: Add libunwind input. Resent-Message-ID: References: <87ftdahvut.fsf@gmx.com> <875ze6ngmg.fsf@nckx> From: Pierre Langlois In-reply-to: <875ze6ngmg.fsf@nckx> Date: Sat, 11 Apr 2020 18:53:29 +0200 Message-ID: <87eesuhsl2.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: Pierre Langlois , 40556@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice writes: > Pierre, > > Pierre Langlois =E5=86=99=E9=81=93=EF=BC=9A >> I wonder what's wrong with backtrace_symbols() in guix, I'm not sure >> how >> to investigate that. For now though, what do you think of using >> libunwind? > > OK, but it should only be included on platforms that require it: Oh sure thing! > > ;; Untested=E2=80=A6 > (inputs > `(=E2=80=A6 > ,@(match (%current-system) > ((or "aarch64-linux" "armhf-linux" =E2=80=A6) > `(("libunwind" ,libunwind))) > (_ `())) > =E2=80=A6)) > > Could you test that? OK, the following patch works for me (tested building for armhf and aarch64 on a rockpro64). I've also added a "FIXME" comment to mention the issue so we can remove/keep it when we have a good understanding of what's going on. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-dovecot-Add-libunwind-input-for-arm.patch Content-Transfer-Encoding: quoted-printable >From ea4c7a2dec7c81951cf0d27cbb669ef39b07de95 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 11 Apr 2020 16:34:01 +0100 Subject: [PATCH] gnu: dovecot: Add libunwind input for arm. * gnu/packages/mail.scm (dovecot)[inputs]: Add libunwind if the system is either aarch64-linux or armhf-linux. --- gnu/packages/mail.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index a6ed776db1..91577f72b1 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -24,7 +24,7 @@ ;;; Copyright =C2=A9 2017 Kyle Meyer ;;; Copyright =C2=A9 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2017, 2018 Rene Saavedra -;;; Copyright =C2=A9 2018, 2019 Pierre Langlois +;;; Copyright =C2=A9 2018, 2019, 2020 Pierre Langlois ;;; Copyright =C2=A9 2018 Alex Vong ;;; Copyright =C2=A9 2018 G=C3=A1bor Boskovits ;;; Copyright =C2=A9 2018, 2019, 2020 Ricardo Wurmus @@ -89,6 +89,7 @@ #:use-module (gnu packages libevent) #:use-module (gnu packages libidn) #:use-module (gnu packages libunistring) + #:use-module (gnu packages libunwind) #:use-module (gnu packages linux) #:use-module (gnu packages lsof) #:use-module (gnu packages lua) @@ -1435,6 +1436,12 @@ facilities for checking incoming mail.") (inputs `(("bzip2" ,bzip2) ("libsodium" ,libsodium) ; extra password algorithms + ;; FIXME: The 'test-backtrace' tests fail on arm when using glibc's + ;; backtrace_symbol() function so fallback to using libunwind. + ,@(match (or (%current-target-system) (%current-system)) + ((or "aarch64-linux" "armhf-linux") + `(("libunwind" ,libunwind))) + (_ '())) ("linux-pam" ,linux-pam) ("lz4" ,lz4) ("openssl" ,openssl) --=20 2.26.0 --=-=-= Content-Type: text/plain Thanks, Pierre --=-=-=--