bug#42947: Chez Scheme libraries are broken

bug#42947: Chez Scheme libraries are broken

[Martin Becze]

[-- Attachment #1.1: Type: text/plain, Size: 598 bytes --]

Chez Scheme libraries are broken. For example `guix environment --ad-hoc
chez-scheme chez-fmt`. chez-fmt will not install (for me) because it is
dependent on chez-srfi and chez-scheme seem unable to locate it.

I think it is because CHEZSCHEMELIBDIRS is not being set. But I'm not
sure why that is happening. The chez-scheme package includes the following


```
(native-search-paths
      (list (search-path-specification
            (variable "CHEZSCHEMELIBDIRS")
            (files (list (string-append "lib/csv" version "-site"))))))
```
Which I think should set it.

-Martin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#42947: [PATCH 1/2] gun: chez-scheme: Create libary directory.

[Martin Becze]

By default chez-scheme seems to be using lib/csv<version> for libaries. This
creates the directory lib/csv<version>-site which the scheme libary packages
expect.

* gnu/packages/chez.scm (chez-scheme): Create libary directory.
---
 gnu/packages/chez.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm
index b80421d3f7..bb584696ae 100644
--- a/gnu/packages/chez.scm
+++ b/gnu/packages/chez.scm
@@ -194,6 +194,8 @@
                     (bin (string-append out "/bin"))
                     (lib (string-append out "/lib"))
                     (name "chez-scheme"))
+               ;; create the folder for libary installation
+               (mkdir (string-append lib "/csv" ,version "-site"))
                (symlink (string-append bin "/scheme")
                         (string-append bin "/" name))
                (map (lambda (file)
-- 
2.28.0

bug#42947: [PATCH 2/2] gnu: chez-srfi: Fix tests.

[Martin Becze]

* gnu/packages/chez.scm (chez-srfi): Added make flags so that chez-scheme
loads the tests correctly.
---
 gnu/packages/chez.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm
index bb584696ae..79a5ad965d 100644
--- a/gnu/packages/chez.scm
+++ b/gnu/packages/chez.scm
@@ -242,7 +242,9 @@ and 32-bit PowerPC architectures.")
      `(("chez-scheme" ,chez-scheme)))
     (arguments
      `(#:make-flags (let ((out (assoc-ref %outputs "out")))
-                      (list (string-append "PREFIX=" out)))
+                      (list (string-append "PREFIX=" out)
+                            "CHEZ=chez-scheme --libdirs ./"
+                            (string-append "chezversion=" ,(package-version chez-scheme))))
        #:test-target "test"
        #:phases (modify-phases %standard-phases
                   (delete 'configure))))
-- 
2.28.0

bug#42947: [PATCH 2/2] gnu: chez-srfi: Fix tests.

[Ludovic Courtès]

Hi,

Martin Becze <mjbecze@riseup.net> skribis:

> * gnu/packages/chez.scm (chez-srfi): Added make flags so that chez-scheme
> loads the tests correctly.

Applied, thanks!

Ludo’.

bug#42947: Chez Scheme libraries are broken

[Ludovic Courtès]

Hi Martin,

Martin Becze <mjbecze@riseup.net> skribis:

> Chez Scheme libraries are broken. For example `guix environment --ad-hoc
> chez-scheme chez-fmt`. chez-fmt will not install (for me) because it is
> dependent on chez-srfi and chez-scheme seem unable to locate it.
>
> I think it is because CHEZSCHEMELIBDIRS is not being set. But I'm not
> sure why that is happening. The chez-scheme package includes the following
>
>
> ```
> (native-search-paths
>       (list (search-path-specification
>             (variable "CHEZSCHEMELIBDIRS")
>             (files (list (string-append "lib/csv" version "-site"))))))
> ```
> Which I think should set it.
>
> -Martin

Martin Becze <mjbecze@riseup.net> skribis:

> By default chez-scheme seems to be using lib/csv<version> for libaries. This
> creates the directory lib/csv<version>-site which the scheme libary packages
> expect.
>
> * gnu/packages/chez.scm (chez-scheme): Create libary directory.
> ---
>  gnu/packages/chez.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm
> index b80421d3f7..bb584696ae 100644
> --- a/gnu/packages/chez.scm
> +++ b/gnu/packages/chez.scm
> @@ -194,6 +194,8 @@
>                      (bin (string-append out "/bin"))
>                      (lib (string-append out "/lib"))
>                      (name "chez-scheme"))
> +               ;; create the folder for libary installation
> +               (mkdir (string-append lib "/csv" ,version "-site"))

This is creating an empty directory, right?  Are you sure this helps?

Isn’t the problem that packages like chez-fmt install libraries in
‘csv-site’ instead of ‘csv1.2.3-site’?

--8<---------------cut here---------------start------------->8---
$ find $(./pre-inst-env  guix build chez-fmt)
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-js.so
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-c.so
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt.so
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.css
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/README
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.html
/gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/VERSION
--8<---------------cut here---------------end--------------->8---

Thanks,
Ludo’.

bug#42947: Chez Scheme libraries are broken

[Martin Becze]

 > This is creating an empty directory, right?  Are you sure this helps?

Yes, I think it solves the problem. On line 92 of the package definition 
we have

```
(native-search-paths
      (list (search-path-specification
             (variable "CHEZSCHEMELIBDIRS")
             (files (list (string-append "lib/csv" version "-site"))))))
```
search-path-specification won't set the environmental variable unless 
the folder already exists. Note lib/csv<version> does exist at this 
point but most libraries seem to want to live lib/csv<version>-site.

On 8/28/20 8:22 AM, Ludovic Courtès wrote:
> Hi Martin,
> 
> Martin Becze <mjbecze@riseup.net> skribis:
> 
>> Chez Scheme libraries are broken. For example `guix environment --ad-hoc
>> chez-scheme chez-fmt`. chez-fmt will not install (for me) because it is
>> dependent on chez-srfi and chez-scheme seem unable to locate it.
>>
>> I think it is because CHEZSCHEMELIBDIRS is not being set. But I'm not
>> sure why that is happening. The chez-scheme package includes the following
>>
>>
>> ```
>> (native-search-paths
>>        (list (search-path-specification
>>              (variable "CHEZSCHEMELIBDIRS")
>>              (files (list (string-append "lib/csv" version "-site"))))))
>> ```
>> Which I think should set it.
>>
>> -Martin
> 
> Martin Becze <mjbecze@riseup.net> skribis:
> 
>> By default chez-scheme seems to be using lib/csv<version> for libaries. This
>> creates the directory lib/csv<version>-site which the scheme libary packages
>> expect.
>>
>> * gnu/packages/chez.scm (chez-scheme): Create libary directory.
>> ---
>>   gnu/packages/chez.scm | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm
>> index b80421d3f7..bb584696ae 100644
>> --- a/gnu/packages/chez.scm
>> +++ b/gnu/packages/chez.scm
>> @@ -194,6 +194,8 @@
>>                       (bin (string-append out "/bin"))
>>                       (lib (string-append out "/lib"))
>>                       (name "chez-scheme"))
>> +               ;; create the folder for libary installation
>> +               (mkdir (string-append lib "/csv" ,version "-site"))
> 
> This is creating an empty directory, right?  Are you sure this helps?
> 
> Isn’t the problem that packages like chez-fmt install libraries in
> ‘csv-site’ instead of ‘csv1.2.3-site’?
> 
> --8<---------------cut here---------------start------------->8---
> $ find $(./pre-inst-env  guix build chez-fmt)
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-js.so
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-c.so
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt.so
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.css
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/README
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.html
> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/VERSION
> --8<---------------cut here---------------end--------------->8---
> 
> Thanks,
> Ludo’.
> 
> 

bug#42947: Chez Scheme libraries are broken

[Ludovic Courtès]

Hi,

Martin Becze <mjbecze@riseup.net> skribis:

>> This is creating an empty directory, right?  Are you sure this helps?
>
> Yes, I think it solves the problem. On line 92 of the package
> definition we have
>
> ```
> (native-search-paths
>      (list (search-path-specification
>             (variable "CHEZSCHEMELIBDIRS")
>             (files (list (string-append "lib/csv" version "-site"))))))
> ```
> search-path-specification won't set the environmental variable unless
> the folder already exists. Note lib/csv<version> does exist at this
> point but most libraries seem to want to live lib/csv<version>-site.

I see, but now we’re creating a directory that remains empty, and as I
wrote, chez-fmt is actually installed in another directory anyway:

>> Isn’t the problem that packages like chez-fmt install libraries in
>> ‘csv-site’ instead of ‘csv1.2.3-site’?
>>
>> --8<---------------cut here---------------start------------->8---
>> $ find $(./pre-inst-env  guix build chez-fmt)
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-js.so
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-c.so
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt.so
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.css
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/README
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.html
>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/VERSION
>> --8<---------------cut here---------------end--------------->8---

So perhaps the search path should be just lib/csv-site?  Is that
consistent across Chez packages?

Thanks,
Ludo’.

bug#42947: Chez Scheme libraries are broken

[Martin Becze]

[-- Attachment #1: Type: text/plain, Size: 2790 bytes --]

 > I see, but now we’re creating a directory that remains empty, and as I
 > wrote, chez-fmt is actually installed in another directory anyway:

Oh yikes! Yeah so I see half of the scheme libraries are installed in 
lib/csv-site and other are installed in lib/csv<version>-site. It 
appears that there was a missing make flag for scheme-fmt and several 
others. Attached is an updated patch that fixes that.

On 8/31/20 3:56 PM, Ludovic Courtès wrote:
> Hi,
> 
> Martin Becze <mjbecze@riseup.net> skribis:
> 
>>> This is creating an empty directory, right?  Are you sure this helps?
>>
>> Yes, I think it solves the problem. On line 92 of the package
>> definition we have
>>
>> ```
>> (native-search-paths
>>       (list (search-path-specification
>>              (variable "CHEZSCHEMELIBDIRS")
>>              (files (list (string-append "lib/csv" version "-site"))))))
>> ```
>> search-path-specification won't set the environmental variable unless
>> the folder already exists. Note lib/csv<version> does exist at this
>> point but most libraries seem to want to live lib/csv<version>-site.
> 
> I see, but now we’re creating a directory that remains empty, and as I
> wrote, chez-fmt is actually installed in another directory anyway:
> 
>>> Isn’t the problem that packages like chez-fmt install libraries in
>>> ‘csv-site’ instead of ‘csv1.2.3-site’?
>>>
>>> --8<---------------cut here---------------start------------->8---
>>> $ find $(./pre-inst-env  guix build chez-fmt)
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-js.so
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt-c.so
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/lib/csv-site/fmt.so
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.css
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/README
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/fmt.html
>>> /gnu/store/qr8mgphbivlqbdmn355kps2cxlmi679d-chez-fmt-0.8.11/share/doc/chez-fmt-0.8.11/VERSION
>>> --8<---------------cut here---------------end--------------->8---
> 
> So perhaps the search path should be just lib/csv-site?  Is that
> consistent across Chez packages?
> 
> Thanks,
> Ludo’.
> 

[-- Attachment #2: v2-0001-gnu-chez-scheme-Fix-libary-directory-issue.patch --]
[-- Type: text/x-patch, Size: 1687 bytes --]

From 328ab304b47671dcdc03768f07484aae298ca646 Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Thu, 20 Aug 2020 12:39:50 -0500
Subject: [PATCH v2 1/2] gnu: chez-scheme: Fix libary directory issue.

This creates the directory lib/csv<version>-site which the scheme libary packages
expect.

* gnu/packages/chez.scm (chez-scheme): Create libary directory.
* gnu/packages/chez.scm (chez-make-flags): Add chezversion to make flags.
---
 gnu/packages/chez.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm
index da0b17e799..ac8fce5a1a 100644
--- a/gnu/packages/chez.scm
+++ b/gnu/packages/chez.scm
@@ -194,6 +194,8 @@
                     (bin (string-append out "/bin"))
                     (lib (string-append out "/lib"))
                     (name "chez-scheme"))
+               ;; create the folder for libary installation
+               (mkdir (string-append lib "/csv" ,version "-site"))
                (symlink (string-append bin "/scheme")
                         (string-append bin "/" name))
                (map (lambda (file)
@@ -416,9 +418,11 @@ Chez Scheme.")
 ;; files.
 (define (chez-make-flags name version)
   `(let ((out (assoc-ref %outputs "out")))
-     (list (string-append "PREFIX=" out)
-           (string-append "DOCDIR=" out "/share/doc/"
-                          ,name "-" ,version))))
+     (list
+      (string-append "chezversion=" ,(package-version chez-scheme))
+      (string-append "PREFIX=" out)
+      (string-append "DOCDIR=" out "/share/doc/"
+                     ,name "-" ,version))))
 
 (define-public chez-matchable
   (package
-- 
2.28.0

bug#42947: Chez Scheme libraries are broken

[Ludovic Courtès]

Hi,

Martin Becze <mjbecze@riseup.net> skribis:

>> I see, but now we’re creating a directory that remains empty, and as I
>> wrote, chez-fmt is actually installed in another directory anyway:
>
> Oh yikes! Yeah so I see half of the scheme libraries are installed in
> lib/csv-site and other are installed in lib/csv<version>-site. It
> appears that there was a missing make flag for scheme-fmt and several
> others. Attached is an updated patch that fixes that.

[...]

> From 328ab304b47671dcdc03768f07484aae298ca646 Mon Sep 17 00:00:00 2001
> From: Martin Becze <mjbecze@riseup.net>
> Date: Thu, 20 Aug 2020 12:39:50 -0500
> Subject: [PATCH v2 1/2] gnu: chez-scheme: Fix libary directory issue.
>
> This creates the directory lib/csv<version>-site which the scheme libary packages
> expect.
>
> * gnu/packages/chez.scm (chez-scheme): Create libary directory.
> * gnu/packages/chez.scm (chez-make-flags): Add chezversion to make flags.

I’ve applied it without the ‘mkdir’.  I confirm it solves the problem:

  echo '(import (fmt))' | ./pre-inst-env guix environment -C --ad-hoc chez-scheme chez-fmt -- chez-scheme

Thanks!

Ludo’.