From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Simon South <simon@simonsouth.net>
Cc: 43823@debbugs.gnu.org
Subject: [bug#43823] [PATCH 2/3] gnu: knot: Build the Info manual.
Date: Tue, 06 Oct 2020 03:10:17 +0200 [thread overview]
Message-ID: <87eemc88hy.fsf@nckx> (raw)
In-Reply-To: <201a17b6e4fe8abb50cf759fe50db1b339b17657.1601941844.git.simon@simonsouth.net>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
Simon,
Simon South 写道：
> This also silences a configure warning about the "sphinx-build"
> command being unavailable.
./configure is a noisy boy; not every ‘warning’ warrants action.
A GNU info manual is definitely nice to have though!
> + ("makeinfo" ,texinfo)
> ("pkg-config" ,pkg-config)
> - ("ragel" ,ragel)))
> + ("ragel" ,ragel)
> + ("sphinx-build" ,python-sphinx)))
It's a subjective line but I'd prefer the labels match the package
here. Nitpick, can be fixed up in post.
Otherwise LGTM,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2020-10-06 1:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 0:25 [bug#43823] [PATCH 0/3] Knot: Enable DoH; build Info manual; work on aarch64-linux Simon South
2020-10-06 0:27 ` [bug#43823] [PATCH 1/3] gnu: knot: Enable DNS-over-HTTPS support in kdig Simon South
2020-10-06 1:11 ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-06 0:27 ` [bug#43823] [PATCH 2/3] gnu: knot: Build the Info manual Simon South
2020-10-06 1:10 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-10-06 0:27 ` [bug#43823] [PATCH 3/3] gnu: knot: Fix test failure on aarch64-linux Simon South
2020-10-06 1:15 ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-06 1:08 ` [bug#43823] [PATCH 0/3] Knot: Enable DoH; build Info manual; work " Tobias Geerinckx-Rice via Guix-patches via
2020-10-06 13:56 ` [bug#43823] [PATCH v2 0/3] Knot: Enable DoH; build Info Manual; " Simon South
2020-10-06 13:56 ` [bug#43823] [PATCH v2 1/3] gnu: knot: Enable DNS-over-HTTPS support in kdig Simon South
2020-10-06 13:56 ` [bug#43823] [PATCH v2 2/3] gnu: knot: Build the Info manual Simon South
2020-10-06 13:56 ` [bug#43823] [PATCH v2 3/3] gnu: knot: Fix test failure on aarch64-linux Simon South
2020-10-06 14:41 ` bug#43823: [PATCH v2 0/3] Knot: Enable DoH; build Info Manual; work " Tobias Geerinckx-Rice via Guix-patches via
2020-10-06 14:49 ` [bug#43823] " Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eemc88hy.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=43823@debbugs.gnu.org \
--cc=me@tobias.gr \
--cc=simon@simonsouth.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.