From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wC/5OS2clF/uTgAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 21:27:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uHvNNS2clF8SBAAAB5/wlQ (envelope-from ) for ; Sat, 24 Oct 2020 21:27:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A45E9402A0 for ; Sat, 24 Oct 2020 21:27:09 +0000 (UTC) Received: from localhost ([::1]:52288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWR48-0006Uc-Dw for larch@yhetil.org; Sat, 24 Oct 2020 17:27:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWR42-0006US-Cc for guix-patches@gnu.org; Sat, 24 Oct 2020 17:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWR42-0001pi-3K for guix-patches@gnu.org; Sat, 24 Oct 2020 17:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWR42-00077J-0W for guix-patches@gnu.org; Sat, 24 Oct 2020 17:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44174] [PATCH 00/16] Add hledger and its dependencies. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44174 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Carlo Holl Cc: 44174@debbugs.gnu.org Received: via spool by 44174-submit@debbugs.gnu.org id=B44174.160357481027337 (code B ref 44174); Sat, 24 Oct 2020 21:27:01 +0000 Received: (at 44174) by debbugs.gnu.org; 24 Oct 2020 21:26:50 +0000 Received: from localhost ([127.0.0.1]:35325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWR3q-00076r-5F for submit@debbugs.gnu.org; Sat, 24 Oct 2020 17:26:50 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWR3p-00076j-9i for 44174@debbugs.gnu.org; Sat, 24 Oct 2020 17:26:49 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id F417D27BBF0; Sat, 24 Oct 2020 22:26:47 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 51e9152c; Sat, 24 Oct 2020 21:26:45 +0000 (UTC) References: <20201023074653.8885-1-carloholl@gmail.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20201023074653.8885-1-carloholl@gmail.com> Date: Sat, 24 Oct 2020 22:26:43 +0100 Message-ID: <87eelnb9ik.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: 5mc1apK6bOpo --=-=-= Content-Type: text/plain Carlo Holl writes: > Guix, > > This patch series adds hledger, a plaintext accounting > program. hledger started as a Haskell reimplementation of Ledger > CLI. I use hledger regularly to manage personal finances and those of > several businesses, and would not be suprised to find other hledger > users in the Guix community. > > More information is available at https://hledger.org. Hi Carlo, thanks for the patches! > A couple of notes: > > 1. The hledger package is placed in (gnu packages finance), and > its dependencies in (gnu packages haskell-xyz). That sounds good :) > 2. The hledger package is *not* prefixed with 'ghc', but its > dependencies are. Also fine. > 3. The package ghc-doctest was bumped (minor version), affecting several dependent packages. > I was able to build most of these affected packages (querying guix refresh --list-dependents), > but it was taking forever so I cut that effort short. I consider this a rough heuristic to determine > that there are no substantial changes associated with this > version bump. Sounds good. > 4. I'm not terribly familiar with the Texinfo format, so there are > likely some rough edges there. Looks like you've done pretty well from what I've seen :) > 5. I am able to build hledger and its dependencies without error, but was unsuccessful building > on different architectures with qemu. I wasn't even able to build GHC under qemu so I didn't bother > digging any further. No problem, if it builds on x86_64-linux, that's good enough at least initially. > This is my first contribution to Guix, and I'm also not a Haskell > expert, so expect some headaches. I am happy to attend to any issues > as best I am able. Great, I'll make some more comments on the individual patches, a few general comments though: - The commits should include changelog entries. For new packages, these are pretty easy to write, it's just: * gnu/packages/FILE.scm (PACKAGE): New variable. - The indentation looks off in places, there's some stuff here about indentation [1]. What editor are you using? 1: https://guix.gnu.org/manual/en/html_node/Formatting-Code.html Let me know if you have any questions, and it would be great if you could send an updated set of patches. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+UnBNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xf5qRAApDLDtQVMWE74SkkADi+k4cxNI6kwCMbr crCGCs74Aw28u1z+f4aFtt8Sxv71FjIH4cauigAc7zDoxGMWYj0iCAfskb+FCU/f C+c2DwLpK+tk7g3O4EysQ0UjAIoACnLYemfN0An/djEBY/cFs6agRLlkuDtptJaq X/uSf+tDtwaRZZC2U6cJ01WzPOdzjvpc8DJgiV5f5I/QbYeVitNb3H2oHRZmYEno wa65uajmwo8y3Y2mIIar3PAZu8Ygrs0k95xNkuxaD9KDNbC/3T8tfjwOMS2w19qz Oy43fI9GcaXQIW22zRuQLRwn5+oUHLeanCPL4JWHEsOoDVClWsZjixkrmpAq/rXt ZdW8Q60sxmTYE9IH5HDAi3A1r/WI9vr8wmMT6xAp1Vg3/WW0a5pOb93GWCv/ZSIw Fwb/4COyFXDhkUV1kqgjlUpxZy1KV9kuRpuTqETX0jYPG7G2bGAmv3jQm3C6C+O1 4/PuKbga9SzQBCbmjyuAjhbVwvVMHvK3QB0G8zkyX2U5uS5385c+33/HcblrTbYt rKvOwd1vBLu6hzh82/TAxoZ90rcDn5dUFnUPLCELZTKpW9TaPIEujyvv4esE5uIL UPqQubbNrdF7d42laU3CuvPQgw1GVYb9c4C+JMST4rcBuNwJr7poirnCl4gkH8iv S9OT6oHGKPY= =3wWf -----END PGP SIGNATURE----- --=-=-=--