From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6NfzHtsObmAYQAAAgWs5BA (envelope-from ) for ; Wed, 07 Apr 2021 21:58:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mLfnGNsObmCxTgAAB5/wlQ (envelope-from ) for ; Wed, 07 Apr 2021 19:58:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 85F9D1C823 for ; Wed, 7 Apr 2021 21:58:18 +0200 (CEST) Received: from localhost ([::1]:40248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUEJd-0006Yu-GB for larch@yhetil.org; Wed, 07 Apr 2021 15:58:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUEJQ-0006Xa-Fp for bug-guix@gnu.org; Wed, 07 Apr 2021 15:58:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUDy5-0001bE-Nd for bug-guix@gnu.org; Wed, 07 Apr 2021 15:36:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lUDy5-0003sU-Kj for bug-guix@gnu.org; Wed, 07 Apr 2021 15:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47569: =?UTF-8?Q?=E2=80=98qt-build-system=E2=80=99?= retains too many references via wrappers Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 07 Apr 2021 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47569 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 47569-submit@debbugs.gnu.org id=B47569.161782416114903 (code B ref 47569); Wed, 07 Apr 2021 19:36:01 +0000 Received: (at 47569) by debbugs.gnu.org; 7 Apr 2021 19:36:01 +0000 Received: from localhost ([127.0.0.1]:45252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUDy4-0003sF-L3 for submit@debbugs.gnu.org; Wed, 07 Apr 2021 15:36:01 -0400 Received: from mail-qv1-f50.google.com ([209.85.219.50]:35438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUDy1-0003rz-Pn for 47569@debbugs.gnu.org; Wed, 07 Apr 2021 15:35:59 -0400 Received: by mail-qv1-f50.google.com with SMTP id x27so9629038qvd.2 for <47569@debbugs.gnu.org>; Wed, 07 Apr 2021 12:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=XnjvAiVVdSaF0nf5HjA61QQMHm/WjkbqPa2RUOBPmAk=; b=N9auRDMeUcAnY/9gmlU7R45hImjIkyNfSYGKQKJl9NPEqe8SuXY7b/YT15pnzZQ6dS rYXqQgm2BXhX+ZvMjKL8u+vqiA4f8m5bMWQbVzlYOaexdYJnNlgIHXAJUgreiOYael+j 5QWtBoNDE7dKFSf4mWIXouD+U3m99hWJ/66bMLlLp1ZHm+ue4p3I61DshDj4T0nIFYr0 Iefy1kPIq/LrZX7hee+4oHTf4ajT3cQQlCXxzOa+ejnXED+KsVo43lrQ7A871C3ImhF+ OF812kydZkYq05nLYyirCPKGTDzkNmnf+bFzQ75/SGPEHTosOC6+Rrx57pdv0vBdy+gC WxWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=XnjvAiVVdSaF0nf5HjA61QQMHm/WjkbqPa2RUOBPmAk=; b=tdbD3Z2F0vGn2FZA1WRr/lSEixkYIU7lpiNnKg01fd8vMX8Mt9JUrTRuMN9yx+c1xX CT/RZVRAeR5tKRk4YRtP2nuGmdsWkmCKxqDGI0QCQGim/oj60KG/P8Io90WTnhXdorTm VETp0z3P97KUYto8rttS3tJavjWFMbvBuSMA/S9z/HmTXoFx+0kx8pKlngS9sCvj01T9 bNCG0RWEaCsp+PoTNV6YdMMrkgUVauc1HAR0mIS8GBSShuS8ZGaRqmQAdktr81vQbhsB V1yq1Q9NEsvGAdfA3zXtRvolmYtsV5R4dq4YRjH2VPY8XcC7VPxtJWxO1DPdci3qSvaE Wt8A== X-Gm-Message-State: AOAM5323AhXeZcITfX8WW4J7DhZY65qxwR/a4m/wnxqAGukm/OZMglzj v4YfMJfRjTX+fJu/ZuQiAqSKZxobOck= X-Google-Smtp-Source: ABdhPJxsxggOSNLDWXYwlPOID+X50b7rx6T1fDVpcfhTGf0524Cwtpewa3XyaPeTRzGn8UVCrWYkOg== X-Received: by 2002:ad4:4862:: with SMTP id u2mr5200825qvy.1.1617824151906; Wed, 07 Apr 2021 12:35:51 -0700 (PDT) Received: from hurd (mtl.savoirfairelinux.net. [208.88.110.46]) by smtp.gmail.com with ESMTPSA id d16sm18963159qka.43.2021.04.07.12.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 12:35:51 -0700 (PDT) From: Maxim Cournoyer References: <87czvczbsv.fsf@inria.fr> <87blaurbya.fsf@gmail.com> <878s5wseaz.fsf@gnu.org> <87r1jnmu0v.fsf@gnu.org> <87zgybl35g.fsf@gnu.org> Date: Wed, 07 Apr 2021 15:35:50 -0400 In-Reply-To: <87zgybl35g.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 06 Apr 2021 19:43:39 +0200") Message-ID: <87eeflopk9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47569@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617825498; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XnjvAiVVdSaF0nf5HjA61QQMHm/WjkbqPa2RUOBPmAk=; b=JP9k5L/nHV2S5WfyFNvU266+lOVV9aQjEgObgODL3r40144ln3vHewlTGeFHLvM8p4T5co QDdXce6p+0kyfV3Kr4nMJvhdvKW64bOAtexgG+kJ97pLhIbkybiV7KPjTMSd0bAlecqcAI Z4WyNmRSNZxxEx75T5k42kr/qSIciCbTh6o7xWMgDEETg8CQ4G4CX3oCO6HIeDAs33csgE 8OPC52ilBYmHGi6j77Odsl+Uxqytq7VYYXN5SXwEFdtjC9PTfg1jnch+OCSQ26guzo19Ay oRnRjDk8PjnnXthm/6X92Yrb5nSfXf79ij6UkwA2gzbNVYkubw61tLZNJRf79w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617825498; a=rsa-sha256; cv=none; b=IryJN3IMKaeiaMdvIQwfyJnLiPWSvfmCI2USWgZFN1BmEP1lbAwJ9P2Jy4YVNXJ97ano9J yfbHcUkcNevQq1zZ+oPVWJaLrI7lPJG8lQslWcPDdqyB7Shm+ydk/qBWootHtfpEOa6D3s 6FwCN784uqMyqRdq0F24sc6wBfrMiMQs+z0pph6hcHu3DpNt3Zmaic3g3JXwALq0wzQbc8 /hx7ycLyWg99fuOYD0EJoThEN6TMalETT1ZowJeGkgLFW5xsYpcVZ4N6Os0NqvJq0tlRig l6oCwh7QLMYKxB8U+3RSjuWRwTVe78SA5JwiRkeJ5KFm7lMUquqZPIh72doUoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=N9auRDMe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=N9auRDMe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 85F9D1C823 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: GWLzoDKxwvgZ Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi again! > > The attached patch fixes this problem AFAICS by filtering out of > XDG_DATA_DIRS directories that are unlikely to be of any use. It > follows the same strategy as =E2=80=98glib-or-gtk-build-system=E2=80=99, = which is to > only include share/ sub-directories that also contain one of the given > =E2=80=9Cselectors=E2=80=9D: /glib-2.0/schemas, /sounds, /themes, etc. > > It gives me a working ktouch, with a wrapper sets a much shorter > XDG_DATA_DIR: > > $ head -2 $(./pre-inst-env guix build --no-grafts ktouch)/bin/ktouch > #!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash > export XDG_DATA_DIRS=3D"/gnu/store/mgzijzw7yn03pbk54zy0f81gyph9jh3k-ktouc= h-20.12.1/share:/gnu/store/5g95qdh0p46qszv199rmdd2lx4mninm7-kcoreaddons-5.7= 0.0/share" > $ head -2 $(guix build --no-grafts ktouch)/bin/ktouch > #!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash > export XDG_DATA_DIRS=3D"/gnu/store/f821syw55jd0l04xkmnbvp562flrw6fm-ktouc= h-20.12.1/share:/gnu/store/3dsl2jalrcyldkrsqab1hc6sv8pyag9z-cmake-minimal-3= .16.5/share:/gnu/store/3x63j4ndhbzkjwr6mhnp4h86r550gs7q-extra-cmake-modules= -5.70.0/share:/gnu/store/w08sglxbfpmcvz25pfgnq7v27m1rlkf9-kdoctools-5.70.0/= share:/gnu/store/krpyb0zi700dcrg9cc8932w4v0qivdg9-pkg-config-0.29.2/share:/= gnu/store/v6f44zccwh9z5zk3pjlywjybbi8n2hjh-tar-1.32/share:/gnu/store/ncydgq= 2znms5n1d2k5yqshhf58nsixwv-gzip-1.10/share:/gnu/store/i8h2pcxqdq07ijm3ibkka= 8f4smn1w48v-bzip2-1.0.8/share:/gnu/store/9860f1abqj8wjjnwl8a9v54pdcc3bhgf-x= z-5.2.4/share:/gnu/store/60g7r3l01fd7c58yjbm6krgcwj1jkpwg-file-5.38/share:/= gnu/store/n4n560pfvvw50a9369axw5vj5rrqfj1n-diffutils-3.7/share:/gnu/store/c= d5qf3kcnlq35p9k392pjdpdzpsnds70-patch-2.7.6/share:/gnu/store/hic7snhayfl7m6= cpfqqr73nmm19bpqkg-findutils-4.7.0/share:/gnu/store/swqdvwri9dbv6zssg6v0by7= l05hd6wxp-gawk-5.0.1/share:/gnu/store/ishk7fswcs4gkwcp8mh788z4mvvl9bxh-sed-= 4.8/share:/gnu/store/bhs4rj58v8j1narb2454raan2ps38xd8-grep-3.4/share:/gnu/s= tore/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/share:/gnu/store/hm40b= xnv8jxmbc1lpb7zfimii4xm9m81-make-4.3/share:/gnu/store/pwcp239kjf7lnj5i4lkdz= cfcxwcfyk72-bash-minimal-5.0.16/share:/gnu/store/m1z7cdbqsqyp9xnjw5cvlb4a7g= kcg3m4-binutils-2.34/share:/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-= 7.5.0/share:/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/share:/g= nu/store/s3dcqzwqaakv1yx37by9chksdbkgih17-glibc-2.31-static/share:/gnu/stor= e/5rj71g09qc9g20mv0lh5a28jhwa5d6dl-kcmutils-5.70.0/share:/gnu/store/3vdmy5g= jn1a23ky6l907byc3917xfh2a-kcompletion-5.70.0/share:/gnu/store/ba8nl7wflsf1s= 95x72kpaj0rzval908b-kconfig-5.70.0/share:/gnu/store/r4120j3v7cnv5qlmp2kqb6x= bc63gplpa-kconfigwidgets-5.70.0/share:/gnu/store/5g95qdh0p46qszv199rmdd2lx4= mninm7-kcoreaddons-5.70.0/share:/gnu/store/lbq73h2snwpn4wf9wkp8j0rxw0lyhyp4= -kdeclarative-5.70.0/share:/gnu/store/k4k0mrgv31clkpl38zjnpb3l0nin2nnl-ki18= n-5.70.0/share:/gnu/store/agmzjiqcv1lb77jmr7xwx0br4sy12i6d-kiconthemes-5.70= .0/share:/gnu/store/0mbm58p5mybimbvv8ainkzz7mdpynd25-kitemviews-5.70.0/shar= e:/gnu/store/yqpk8haa1z5plgb134f95vryjxghlyjv-kqtquickcharts-20.04.1/share:= /gnu/store/5mfz0faj9lc9m1ppijgqkxz03j89dyil-ktextwidgets-5.70.0/share:/gnu/= store/fwmp85k5hqy7fw0rnq5560pg4amiblz4-kwidgetsaddons-5.70.0/share:/gnu/sto= re/xslnsy6sxjp66l99mvj67v1x30bh55xi-kwindowsystem-5.70.0/share:/gnu/store/n= 79ns6y3cc7ny4mkp5qidf57j1cxbg6p-kxmlgui-5.70.0/share:/gnu/store/3x6y8kpbwjm= zpndjfhdbn654g7dm85cp-libxcb-1.14/share:/gnu/store/zc9bpa1v46cnqc05xk8njm08= bwk8a70m-libxkbfile-1.1.0/share:/gnu/store/j7110r2rhs9pdypx2x0h8nx4r082fbdk= -qtbase-5.15.2/share:/gnu/store/8r5y5bnblc4s6w8j5sfxv06ra6lz12j8-qtdeclarat= ive-5.15.2/share:/gnu/store/c020rcd650ikq7gqfnkga46kzis3v2hi-qtgraphicaleff= ects-5.15.2/share:/gnu/store/2iwman5hbgg15r99rshl6lsxz35dq2b2-qtquickcontro= ls2-5.15.2/share:/gnu/store/n7dbg5cgcpslrym4zmsimps1ch1p0q8w-qtx11extras-5.= 15.2/share:/gnu/store/7yjd1h08li3dr2188pfwfnwlq0p3av9p-qtxmlpatterns-5.15.2= /share:/gnu/store/gfapkk5c6hvl1d94m4sqnhn7f9l5gqyh-linux-libre-headers-5.4.= 20/share:/gnu/store/kvdrfyi50zsmy0ykmc9p8qzjlahqfa4p-kservice-5.70.0/share:= /gnu/store/yk425lbm0wnjpqm1z964l9l6li5x0wbn-kcodecs-5.70.0/share:/gnu/store= /2z5nfmzxhqaalcrswp8nn3yk5ys8q261-kauth-5.70.0/share:/gnu/store/vhmyxywsdy9= 2bgqxy6fnmcpr81xsfcys-kpackage-5.70.0/share:/gnu/store/rz42ba0my9vrgbkjpkzr= 2drmnjk5ah50-python-3.8.2/share:/gnu/store/n9wx4dp68bfsw9bb1bwmklzl34ggrmgm= -gettext-minimal-0.20.1/share:/gnu/store/yqs5mkp20m58sr744cs2pn8sqb5m59sq-s= onnet-5.70.0/share:/gnu/store/6cdl970wcv4jhvpgbh8sdj54a5gwhmwj-libxdmcp-1.1= .3/share:/gnu/store/h7sy4hr7arjknbyy1aq0xwv6fksnzw9n-libxau-1.0.9/share:/gn= u/store/klk98l8czl05lvanrr7xl7a9hksac4ak-libpthread-stubs-0.4/share:/gnu/st= ore/k30a2pgmc6b3ifmq3rn0dr5ng9gr8w81-which-2.21/share:/gnu/store/7disnxqw8i= 3n4zhw5s0xj9kkdckkmr1p-mesa-20.2.4/share:/gnu/store/wxl57nkbqgamfp73b7v62kk= 3f1hiv0cz-xorgproto-2019.2/share:/gnu/store/c3zbbynb590yxrpwcxrkll80mn66h3k= f-libxxf86vm-1.1.4/share:/gnu/store/jwga98k68l0h5c45jx7z4jdjzhfc34vm-libxsh= mfence-1.3/share:/gnu/store/9z9gd76la5bww3sqgg2ax0h00msl28k6-libxfixes-5.0.= 3/share:/gnu/store/2wysr1lr7b5mc444m39qz107n92xm5xq-libxdamage-1.1.5/share:= /gnu/store/fx3979c88s9yxdbchyf36qryawgzpwb5-libx11-1.6.10/share:/gnu/store/= kx58xc3hxa9b0mp1hl7pzz43bl7gh18h-libdrm-2.4.103/share:/gnu/store/lc8irxnwaz= q340ygkbqh0ask446jzy9k-util-macros-1.19.2/share:/gnu/store/qrs0p8j3wq6q5a4d= m0ndjdavk9gyal5q-libxext-1.3.4/share" > > > The closure is still awfully big but smaller: > > $ ./pre-inst-env guix size ktouch | tail -1 > total: 1298.0 MiB > $ guix size ktouch | tail -1 > total: 1752.4 MiB > > Thoughts? > > Ludo=E2=80=99. Thanks for the patch! I built jami-qt with it; the closure size was reduced from 2.7 GiB to 2.2 GiB (there's probably more to do, but it's a good start!). It seems to work just as well as before the change, from a cursory look. LGTM! Thank you, Maxim