bug#47761: Guile Segfaulting on guix build -f

bug#47761: Guile Segfaulting on guix build -f

[Nicolò Balzarotti]

Hi guix!

A package definition that used to build fine, recently (don't know
exactly when) started failing, with guile segfaulting.

After removing a few things, it seems that the MWE is this:

echo '(use-modules (guix git-download)) (git-predicate "repo")'>m.scm
mkdir repo
guix build -f m.scm
Segmentation fault

guix describe:

guix 2a62425
   repository URL: https://git.savannah.gnu.org/git/guix.git
   branch: master
   commit: 2a624253bc55e2a94f6581d6e790303575436c96

One of the two computers provides substitute to the other, so maybe my
guile is somehow damaged?  Can any of you reproduce it?

Thanks, Nicolò

bug#47761: Guile Segfaulting on guix build -f

[Nicolò Balzarotti]

Nicolò Balzarotti <anothersms@gmail.com> writes:

> mkdir repo
> guix build -f m.scm
> Segmentation fault

I wanted to add that

$ guile m.scm

does not crash, don't know if this is of any help

bug#47761: Guile Segfaulting on guix build -f

[Julien Lepiller]

Le Tue, 13 Apr 2021 23:36:40 +0200,
Nicolò Balzarotti <anothersms@gmail.com> a écrit :

> Hi guix!
> 
> A package definition that used to build fine, recently (don't know
> exactly when) started failing, with guile segfaulting.
> 
> After removing a few things, it seems that the MWE is this:
> 
> echo '(use-modules (guix git-download)) (git-predicate "repo")'>m.scm
> mkdir repo
> guix build -f m.scm
> Segmentation fault
> 
> guix describe:
> 
> guix 2a62425
>    repository URL: https://git.savannah.gnu.org/git/guix.git
>    branch: master
>    commit: 2a624253bc55e2a94f6581d6e790303575436c96
> 
> One of the two computers provides substitute to the other, so maybe my
> guile is somehow damaged?  Can any of you reproduce it?
> 
> Thanks, Nicolò
> 
> 
> 

I can reproduce the segfault when "repo" is a directory that exists
(seems to be independent from content, I can reproduce with an empty
directory and an actually git repository), from guix repl:

scheme@(guix-user)> (use-modules (guix git-download))
scheme@(guix-user)> (git-predicate "repo")
Erreur de segmentation

bug#47761: Guile Segfaulting on guix build -f

[Leo Prikler]

Hi Nicolò

Am Dienstag, den 13.04.2021, 23:36 +0200 schrieb Nicolò Balzarotti:
> Hi guix!
> 
> A package definition that used to build fine, recently (don't know
> exactly when) started failing, with guile segfaulting.
> 
> After removing a few things, it seems that the MWE is this:
> 
> echo '(use-modules (guix git-download)) (git-predicate "repo")'>m.scm
> mkdir repo
> guix build -f m.scm
> Segmentation fault
> 
> guix describe:
> 
> guix 2a62425
>    repository URL: https://git.savannah.gnu.org/git/guix.git
>    branch: master
>    commit: 2a624253bc55e2a94f6581d6e790303575436c96
> 
> One of the two computers provides substitute to the other, so maybe
> my
> guile is somehow damaged?  Can any of you reproduce it?
I managed to somewhat isolate the bug even further:

  (let* ((directory  (string-append (canonicalize-path directory) "/"))
         (dot-git    (repository-discover directory)) ; <- here
         (repository (repository-open dot-git))
         (workdir    (repository-working-directory repository))
         (head       (repository-head repository))
         (oid        (reference-target head))
         (commit     (commit-lookup repository oid))
         (tree       (commit-tree commit))
         (files      (tree-list tree)))

repository-discover is an FFI call into libgit2, that appears to be
segfaulting while… trying to prettify some filename?  At least that's
what "git_path_prettify", which lies on the call trace sounds like.

Regards,
Leo

bug#47761: Guile Segfaulting on guix build -f

[Ludovic Courtès]

Hi Nicolò,

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> A package definition that used to build fine, recently (don't know
> exactly when) started failing, with guile segfaulting.
>
> After removing a few things, it seems that the MWE is this:
>
> echo '(use-modules (guix git-download)) (git-predicate "repo")'>m.scm
> mkdir repo
> guix build -f m.scm
> Segmentation fault

This is now fixed:

  https://issues.guix.gnu.org/47797

Thanks!

Ludo’.